Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hasselblad X2D 100C compressed FFF support #469

Merged
merged 1 commit into from
May 4, 2023

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented May 3, 2023

@kmilos kmilos requested a review from LebedevRI as a code owner May 3, 2023 09:32
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fa6a4ed) 59.18% compared to head (54718eb) 59.18%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #469   +/-   ##
========================================
  Coverage    59.18%   59.18%           
========================================
  Files          231      231           
  Lines        13788    13788           
  Branches      1922     1922           
========================================
  Hits          8161     8161           
  Misses        5492     5492           
  Partials       135      135           
Flag Coverage Δ
benchmarks 8.30% <0.00%> (ø)
integration 47.47% <100.00%> (ø)
linux 56.98% <100.00%> (ø)
macOS 18.96% <0.00%> (ø)
rpu_u 47.47% <100.00%> (ø)
unittests 18.32% <0.00%> (ø)
windows ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...brawspeed/decompressors/HasselbladDecompressor.cpp 74.35% <100.00%> (ø)
...brawspeed/decompressors/HasselbladLJpegDecoder.cpp 75.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LebedevRI
Copy link
Member

@kkempter-getswift could you please follow the guideline outlined on the RPU,
i.e. please provide all the nessesary samples (i.e. all 4?, including re-shooing existing samples)
from said camera of the same scene, ideally something like daylight landscape?

@kmilos
Copy link
Contributor Author

kmilos commented May 4, 2023

Looks good to me for both 3FR and FFF w/ the new samples, thanks @kkempter-getswift

image

@LebedevRI
Copy link
Member

Thank you!

@LebedevRI LebedevRI merged commit be1f9a5 into darktable-org:develop May 4, 2023
42 of 43 checks passed
@kmilos kmilos deleted the hassy_x2d_fff branch May 4, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

None yet

2 participants