Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chore): include and choose tags #10

Merged
merged 3 commits into from Nov 23, 2022
Merged

fix(chore): include and choose tags #10

merged 3 commits into from Nov 23, 2022

Conversation

darkweak
Copy link
Owner

@darkweak darkweak commented Nov 22, 2022 •
edited

Closes #8
Closes #5
Blocked by #9

@darkweak darkweak added the bug Something isn't working label Nov 22, 2022
@darkweak darkweak self-assigned this Nov 22, 2022
@darkweak darkweak force-pushed the fix/chore/esi/include-and-choose-tags branch from 5b3cbb2 to 80b3195 Compare November 22, 2022 22:09
@dkarlovi
Copy link
Contributor

@darkweak I can see you've branched off #9 here, I think I'll close #9 then because if I push there, you'll get conflicts here. Feel free to change the code how you see fit. 👍

@dkarlovi dkarlovi mentioned this pull request Nov 23, 2022
Closed
@darkweak
Copy link
Owner Author

I could rebase after your updates then but it's okay. 😅

@darkweak darkweak merged commit 9298fae into master Nov 23, 2022
@darkweak
Copy link
Owner Author

Thanks for your contribution @dkarlovi! 🚀

@dkarlovi
Copy link
Contributor

Thanks for your support! 🍾

@darkweak darkweak deleted the fix/chore/esi/include-and-choose-tags branch November 23, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@darkweak darkweak

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@darkweak @dkarlovi