-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: customization of cache key #444
Comments
On an unrelated note, I seem to witness some worrisome behavior with cache output being randomly broken
This is with the example Caddyfile from this repo. Had similar behavior with browser on another OS (this one is ran on Windows), but managed to solve it by disabling gzip seemingly (or by explicitly providing Accept-Encoding as one of headers to be part of the cache key. But the weird thing is:
|
Look at the mismatch of Content-Length header when it's cache miss or hit
The above is on Windows with caddy downloaded freshly from their site with Souin selected as the only addon. |
@darkweak I think that'd be it yeah, at very first I didn't realize it was related to ESI |
I have to check why it returns a bad |
@p0358 your PR is ready, thank you for your contribution! 🚀 |
This should probably be closed, I made a new feature request about the custom key #513 |
In the linked PR above, you'll be able to set your own template.
|
Currently it's pretty much just hardcoded to
method+scheme+host+key+query+body+headerValues
, with the ability to drop some of these fields, but not to add new ones. Only the option to specify request headers gives us some flexibility with which I was allowed to do that:also gotta do this in main config for that:
Now that is pretty hacky and cumbersome. Wouldn't it be nice if we could specify a custom pattern that could be added or even replace the key with something custom?
Such as:
The text was updated successfully, but these errors were encountered: