Fix panic when parsing slice of string in Traefik plugin #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkweak
approved these changes
Jan 7, 2022
There was a problem hiding this comment.
LGTM and I trust you on the fact TræfikEE manage in a different way the parsing configuration.
Ty for this work @kevinpollet. By the way you can add your username in the credits section in the main README.
|
Thank you @kevinpollet ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Because the plugin configuration parsing is done differently in TraefikEE and Traefik Proxy, the configuration object given to the souin plugin is respectively different. This is why the code to parse this object was only working in the TraefikCE case.
Therefore, this pull request fixes the parsing in the souin plugin to work for both kinds of input.
Fixes #163