Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chore): race condition and panic in singleflight process #434

Merged
merged 8 commits into from
Jan 10, 2024
Merged

fix(chore): race condition and panic in singleflight process #434

merged 8 commits into from
Jan 10, 2024

Conversation

darkweak
Copy link
Owner

@darkweak darkweak commented Jan 4, 2024

Closes #433

@darkweak darkweak added the bug Something isn't working label Jan 4, 2024
@darkweak darkweak self-assigned this Jan 4, 2024
vejipe
vejipe reviewed Jan 8, 2024
View reviewed changes
pkg/middleware/middleware.go Outdated Show resolved Hide resolved
vejipe
vejipe approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@vejipe vejipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, apart from minor changes (see comments)

@darkweak darkweak force-pushed the fix/chore/singleflight/race-condition-and-panic branch from 047fc42 to 551f3db Compare January 9, 2024 14:57
@darkweak darkweak merged commit d7c2715 into master Jan 10, 2024
20 checks passed
@darkweak darkweak deleted the fix/chore/singleflight/race-condition-and-panic branch January 11, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vejipe vejipe vejipe approved these changes

Assignees

@darkweak darkweak

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic in Caddy plugin
2 participants
@darkweak @vejipe