fix(chore): Send upstream 50x error instead of failing #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vejipe
force-pushed
the
fix/chore/send-upstream-error-instead-of-failing
branch
from
575a8f0
to
501b021
Compare
vejipe
changed the title
darkweak
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to cache-test.fyi:
heuristic-502-not_cached,heuristic-503-not_cached,heuristic-504-not_cached.At the end of ServeHTTP, if Upstream returns a
upstreamErrorerror, the error is returned (e.g., to Caddy) and the server will with500 Internal server error. Instead, the upstream error should be sent back 50x errors to the client.