Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: support /me switch #12

Closed
dietmarw opened this issue Feb 24, 2016 · 7 comments
Closed

enhancement: support /me switch #12

dietmarw opened this issue Feb 24, 2016 · 7 comments

Comments

@dietmarw
Copy link
Contributor

Here another nice function from IRC. Using the /me switch one can express things like

/me really would like this feature

as

@dietmarw* really would like this feature

Not important but nice to have.

seripap added a commit that referenced this issue Feb 24, 2016
@seripap
Copy link
Collaborator

seripap commented Feb 24, 2016

This is actually part of the initial work effort when I started building slash command support. Should be baked 👍

@dietmarw
Copy link
Contributor Author

Sorry but it does not work as expected. It does now do the same as /nick but what it should do is display the current nick simply in boldface and with star at the end /me or /action in IRC

(at least that is the standard IRC behaviour)

@seripap
Copy link
Collaborator

seripap commented Feb 24, 2016

More or less styling- I just opted with the asterisk to be the prefix versus following the username. The functionality is there, we can always look into restyling it before we release 👍
screenshot 2016-02-24 09 41 43

@dietmarw
Copy link
Contributor Author

How strange. I'm on edfab8a and just did once again:

npm install
npm start

Anything else I should do to test the current version?

@seripap
Copy link
Collaborator

seripap commented Feb 24, 2016

try

gulp bundle
npm start

We'll finalize how to build the source correctly after we fix our testing framework

@dietmarw
Copy link
Contributor Author

Ha you beat me to it. Was just saying that I ran a total clean up and a gulp bundle in addition :-)
Thanks. Now it works as expected.

@dietmarw
Copy link
Contributor Author

Would it be possible to use the nick colour for the line instead of green for all who use /me ...?

@seripap seripap added this to the v1.5 - Slash Commands milestone Feb 26, 2016
alanfriedman pushed a commit that referenced this issue May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants