-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order can be null #156
Comments
I forgot to add what is in the console:
|
Hi! I could indeed reproduce the issue with DataTables v2.0.1.
Reference: https://cdn.datatables.net/2.0.0/ I think removing the |
By the first glance over the code, I also think it will be enough. I think the |
The "order" attribute can be empty in two cases: - when setting "ordering: false" Reference: https://datatables.net/reference/option/ordering Related: #107 - with DataTabbles 2.0 > Columns can now have three ordering states - asc, desc or data index order (specified by an empty string). The columns.orderSequence option has been updated to make use of this, so the third ordering on a column will now take it back to the index order, rather than returning to the first direction. Reference: https://cdn.datatables.net/2.0.0/ Related: #156
On the latest datatables implementation, when you click on the order headers, there is 3 options. Ascending, descending and none. The spring-data-jpa-datatables plugin works on the first two, but fails on 3rd becasue of the validation in
DataTablesInput
for the field "order" which is@NotEmpty
To reproduse, just click more than twice on the order header on any column. You will see that the arrows toggles to ASC, DESC and the third option is basically none. I this third case, the request looks like this:
No "order" in the request. This causes an error.
The text was updated successfully, but these errors were encountered: