Restrict eager loading to @OneToOne and @OneToMany relationships #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a JOIN FETCH was also added when dealing with a relationship that may return multiple lines (@OneToMany, for example). Since Hibernate doesn't know how many lines it will need to construct your entities, it fetches a lot of lines and store them in memory, resulting in a big performance hit. In that case, the following warning is dislayed: "HHH000104: firstResult/maxResults specified with collection fetch; applying in memory!". That commit thus restricts JOIN FETCH to @OnetoOne and @manytoone relationships.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a JOIN FETCH was also added when dealing with a
relationship that may return multiple lines (@OneToMany, for example).
Since Hibernate doesn't know how many lines it will need to construct
your entities, it fetches a lot of lines and store them in memory,
resulting in a big performance hit. In that case, the following warning
is displayed: "HHH000104: firstResult/maxResults specified with
collection fetch; applying in memory!". That commit thus restricts JOIN
FETCH to @OnetoOne and @manytoone relationships.
Fixes #38