Add null filter #44
Merged
Add null filter #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the ability to search for null values from a dataTables search string.
For example, say there are 3 possible values for a column:
Sent, Received, Unknown, yet it is a nullable column. To findSentandUnknownrows the filter isSent+Unknown. However, NULL could be interpreted asUnknowntoo.With this modification you can specify
Sent+Unknown+NULLto see rows with null values. In order to look for the textNULL, escape the value as\NULL.Changes:
Added a constants for NULL and escaped NULL.
Added code to look for NULL in the list of values and remove it
Added code to look for NULL in a list of boolean tests
Added code to add “column IS NULL” when necessary
Added code to look for NULL as a single value and handle appropriately
Added unit tests to cover all the paths and options