Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Python 3.7 #5

Merged
merged 6 commits into from
Nov 10, 2022
Merged

Add support for Python 3.7 #5

merged 6 commits into from
Nov 10, 2022

Conversation

murilo-cunha
Copy link
Contributor

Adds support for Python 3.7! 🎉

Closes #2

Summary of changes:

  • Include importlib-metadata as a dev dependency (is included in Python 3.8)
  • Use "old" type hints (typing.List, ...)
  • Code blacked ✅
  • Added last commit to pass mypy checks ✅
    • Include typing stubs for PIL
    • Small refac on PIL types
    • (I can drop this if this too)
  • Tests are not passing - missing .sample_data/images - see Tests not passing #4

darrenburns
darrenburns approved these changes Nov 10, 2022
View reviewed changes
Copy link
Owner

@darrenburns darrenburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

@darrenburns darrenburns merged commit ae8e5ee into darrenburns:master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenburns darrenburns darrenburns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.7 support
2 participants
@murilo-cunha @darrenburns