Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin config bug fix #331

Merged
merged 3 commits into from
Jun 12, 2022
Merged

Plugin config bug fix #331

merged 3 commits into from
Jun 12, 2022

Conversation

petereon
Copy link
Contributor

@petereon petereon commented Jun 1, 2022

This PR addresses the #330

Changes:

  • set_defaults_from_config now returns the config instead of string location of the config file
  • test command picks up plugin config before dropping the rest of config and passes it to config object
  • del statement instead of .pop method to be more explicit about the intent

@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #331 (91cd2a7) into master (7ac8b63) will increase coverage by 0.33%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
+ Coverage   84.59%   84.92%   +0.33%     
==========================================
  Files          21       21              
  Lines        1843     1844       +1     
  Branches      283      283              
==========================================
+ Hits         1559     1566       +7     
+ Misses        240      236       -4     
+ Partials       44       42       -2     
Impacted Files Coverage Δ
ward/_config.py 96.10% <100.00%> (+5.19%) ⬆️
ward/_run.py 85.58% <100.00%> (+0.13%) ⬆️
ward/_utilities.py 90.00% <0.00%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ac8b63...91cd2a7. Read the comment docs.

@petereon
Copy link
Contributor Author

Hi @darrenburns, do you think this will work? Apologies for impatience, I sort of depend on it for ward_coverage extension.

@darrenburns
Copy link
Owner

@petereon I'll try and have a look on Sunday

@darrenburns
Copy link
Owner

Looks good to me, thanks!

@darrenburns darrenburns merged commit 9bdb0f6 into darrenburns:master Jun 12, 2022
@petereon
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants