Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only re-indent after rewriting asserts in Py <3.11 #353

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

AndydeCleyre
Copy link
Contributor

I don't know if or why this makes sense, but it seems to get tests running and passing across Python versions, fixing #352.

Please have a look. Maybe there's a better change to make, but I hope this will be useful in the process of figuring that out.

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 84.92% // Head: 84.88% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (5e4eefb) compared to base (ce9464d).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
- Coverage   84.92%   84.88%   -0.04%     
==========================================
  Files          21       21              
  Lines        1844     1846       +2     
  Branches      283      284       +1     
==========================================
+ Hits         1566     1567       +1     
  Misses        236      236              
- Partials       42       43       +1     
Impacted Files Coverage Δ
ward/_rewrite.py 97.26% <80.00%> (-1.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@darrenburns darrenburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for digging into this. Looks good.

@darrenburns darrenburns merged commit 6730311 into darrenburns:master Nov 3, 2022
@AndydeCleyre
Copy link
Contributor Author

I still don't know for sure if the behavior change in Python was entirely intentional. If not, it might get reverted....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants