Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Make the Action Faster #2

Closed
aditya-mitra opened this issue May 31, 2021 · 2 comments · Fixed by #3
Closed

[FEATURE REQUEST] Make the Action Faster #2

aditya-mitra opened this issue May 31, 2021 · 2 comments · Fixed by #3

Comments

@aditya-mitra
Copy link
Collaborator

aditya-mitra commented May 31, 2021 •
edited
Loading

First of all, excellent action for uploading search indexes to algolia!
I am using it it for a documentation repo.

Currently, the action is taking around 1.5 mins to complete which is according to me okay but can be certainly improved.

on github actions

If we can speed up the build using caching, it would be awesome.
I found one example: https://pythonspeed.com/articles/speeding-up-docker-ci/

If this idea can work out, I am willing to collaborate.
Thank you.
@darrenjennings
Copy link
Owner

If this idea can work out, I am willing to collaborate.

I would gladly accept a PR!

First of all, excellent action for uploading search indexes to algolia!

thank you!

@aditya-mitra
Copy link
Collaborator Author

Okay, I will try to make a pull request within the next 2 weeks.

@aditya-mitra aditya-mitra mentioned this issue Jun 23, 2021
Merged
darrenjennings pushed a commit that referenced this issue Jun 23, 2021
@aditya-mitra
refactor(perf): make the action faster (#3)
e3b8c55 
## Summary

Instead of using the docker image by algolia for docsearch, this pr uses the source repository for scrapping and uploading to algolia.

## Details

Using the source repository, removes the use of jq, installation of docker-cli, the algolia docsearch docker image, and other peer dependencies.

Using the python:3.6 as the base image (which comes with git preinstalled), first the algolia-docsearch repository is git cloned.
pipenv is installed and then pipenv installed the packages in the Pipfile.

## Improvements

The running time of the action has now reduced by 40 seconds.

## Further Comments

I have made a few other fixes/corrections like correcting the spelling of algolia.

Also, I changed the config.example.json since it took a lot of time to index and the difference could not have been made clear.

Closes #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[IMPROVE] Make the Action faster
2 participants
@darrenjennings @aditya-mitra