Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change beginning/end of certificate check to make carriage returns optional #1

Merged

Conversation

bamill88
Copy link
Contributor

Though I am using Windows, the certificates I am working with were generated by a Linux system and thus did not have carriage return characters (\r), only line feeds (\n). To allow this module to work with these certificates, I replaced the StartsWith/EndsWith string checks with Regex -match comparisons and used a pattern which allows for an optional carriage return character.

@darrenjrobinson
Copy link
Owner

Thanks for the PR.
That approach is much better than what I had.
I'm travelling so will do a review early next week, update the version, sign and re-publish.

@darrenjrobinson darrenjrobinson self-assigned this May 24, 2024
@darrenjrobinson darrenjrobinson added the enhancement New feature or request label May 24, 2024
@darrenjrobinson darrenjrobinson merged commit 24f3f4c into darrenjrobinson:master May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants