Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API changes for room details #16

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

jemagu
Copy link

@jemagu jemagu commented Aug 13, 2019

Hi

On July 19 Cisco informed that the sipAddress field on the room object i deprecated and will be removed on the September 30 2019. The sipAddress can now be obtained via a separate Room Meeting Details call. I have made the necessary changes.

https://developer.webex.com/docs/api/changelog

Add new model for MeetingDetails
Add new rest call in SparkRooms (GetRoomMeetingDetailsAsync)
Remove sipAddress from Room model

Add new model for MeetingDetails
Add new rest call in SparkRooms (GetRoomMeetingDetailsAsync)
Remove sipAddress from Room model
@darrenparkinson darrenparkinson merged commit 0b2ca95 into darrenparkinson:master Aug 20, 2019
@darrenparkinson
Copy link
Owner

Thanks for the PR. I've been meaning to revisit this since there have been a number of changes, not least of which is the name. I was considering starting a new repo possibly. Any input you have greatly appreciated. Thanks again.

@jemagu
Copy link
Author

jemagu commented Sep 6, 2019

Thanks for merging the PR. Im not sure if a new repo is necessary i think the current code is easy to understand and easy to modify, a couple of tests would be nice though. Are you planning to release the latest version at nuget.org?

@darrenparkinson
Copy link
Owner

Yes, some tests would definitely be a good idea. It’s a fairly manual script I use at the moment. I’d be happy to accept a PR if you fancy the task ;).

I should put this on nuget— it was a painful experience last time I had to do it, but I’ll see if I can get that done soon.

Thanks again.

@darrenparkinson
Copy link
Owner

Hi @jemagu I've just uploaded 1.2.5 to nuget.org. Let me know how you get on. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants