Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made it faster a couple of times #3

Merged
merged 2 commits into from Aug 16, 2017
Merged

Conversation

streamich
Copy link
Contributor

Wrote it such that it does not use .slice() on every step, this way it is 2-3x faster, given how popular this package is on NPM.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 59cf2d5 on streamich:master into 6dd7a71 on darsain:master.

1 similar comment
@coveralls
Copy link

coveralls commented Aug 14, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 59cf2d5 on streamich:master into 6dd7a71 on darsain:master.

@streamich streamich mentioned this pull request Aug 15, 2017
Closed
@streamich
Copy link
Contributor Author

I don't think the Travis build fails because of my PR.

@darsain
Copy link
Owner

darsain commented Aug 15, 2017

Yeah there is some npm issue on travis for older node version it seems.

Looks good, but can you remove the package-lock.json?

@streamich
Copy link
Contributor Author

Removed package-lock.json

@coveralls
Copy link

coveralls commented Aug 15, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 82cbc9f on streamich:master into 6dd7a71 on darsain:master.

@darsain
Copy link
Owner

darsain commented Aug 16, 2017

Thank you. Published as 1.1.0.

@darsain darsain merged commit f4576e3 into darsain:master Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants