Bring Project and CI Up-to-date #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zanbaldwin
commented
Mar 28, 2024
zanbaldwin
commented
- Test against PHP versions 5.6 to 8.3
- Use PHPStan on max level
zanbaldwin
force-pushed
the
feature/phpstan
branch
2 times, most recently
from
e77913a
to
4e5e950
Compare
So that people can easily see that static analysis is used, even if they aren't mentioned in Composer's require-dev.
I have much more experience with PHPStan than with Psalm. Stick to what you know best.
zanbaldwin
force-pushed
the
feature/phpstan
branch
from
4e5e950
to
a2efa2f
Compare
Ignore the errors that only occur because we have guard clauses for lower PHP versions
zanbaldwin
force-pushed
the
feature/phpstan
branch
2 times, most recently
from
b0bbdc2
to
4204037
Compare
zanbaldwin
force-pushed
the
feature/phpstan
branch
from
4204037
to
5128ad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.