Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

demo cleanup into single directory #624

Closed
mhevery opened this issue Feb 26, 2014 · 7 comments
Closed

demo cleanup into single directory #624

mhevery opened this issue Feb 26, 2014 · 7 comments
Milestone

Comments

@mhevery
Copy link
Contributor

mhevery commented Feb 26, 2014

Currently the demo folder his different directories for each demo. This makes it hard to maintain. Need a single directory for all demos, each demo different name. This way single pub serve can serve them all.

@mhevery mhevery added this to the v1.0 milestone Feb 26, 2014
@shailen
Copy link

shailen commented Feb 28, 2014

Can I recommend not folding everything into a single folder. It may be easier to maintain, but it shows a pattern that we don't want people to use. I've noticed that when we write a sample of any kind, users pretty much copy and paste what they see. Besides, knowing how to structure an AngularDart app into the correct directories is a useful thing that we can pass along to our users. Let's use the web/, lib/, test/ structure recommended for Dart apps?

vicb added a commit to vicb/angular.dart that referenced this issue Mar 6, 2014
vicb added a commit to vicb/angular.dart that referenced this issue Mar 6, 2014
vicb added a commit to vicb/angular.dart that referenced this issue Mar 6, 2014
vicb added a commit to vicb/angular.dart that referenced this issue Mar 6, 2014
@mhevery
Copy link
Contributor Author

mhevery commented Mar 6, 2014

@shailen can you tell me more about your concern? Having multiple demo folders on which we quick test angularDart is real pain point for us. I don't see how anyone could assume that they should put multiple apps into a single folder.

@mhevery
Copy link
Contributor Author

mhevery commented Mar 6, 2014

Would changing the folder name from demo to test_app help clear up the confusion?

@shailen
Copy link

shailen commented Mar 6, 2014

I would recommend changing demo/ to example/. This is the official Pub recommendation. And then making each app its own folder inside example/. So example/todo, etc. And then within each example, I would configure the code carefully so that reusable code goes under lib/, web code goes under web/ and test code under test/. Also, Pub does the right thing for packages/ in subdirectories of example/, so if you wanted, you could have a common pubspec.yaml for all the apps.

Honestly, you'd be surprised how much people cut and paste. Its always better to followed best practices.

mhevery pushed a commit to mhevery/angular.dart that referenced this issue Mar 7, 2014
mhevery pushed a commit to mhevery/angular.dart that referenced this issue Mar 7, 2014
mhevery pushed a commit to mhevery/angular.dart that referenced this issue Mar 7, 2014
@vicb vicb closed this as completed in 1ca6d17 Mar 7, 2014
@chalin
Copy link
Contributor

chalin commented Mar 14, 2014

I don't know if this is related, but now some of the links to angular_dart samples (dartlang.org) are broken. See https://www.dartlang.org/samples/#angular_dart

@vicb
Copy link
Contributor

vicb commented Mar 14, 2014

They work for me. What kind of error do you see ? what browser ?

@chalin
Copy link
Contributor

chalin commented Mar 14, 2014

Sorry, not the demos themselves, the link to the sources. E.g., ToDo source yields a 404.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants