This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
Allow specifying a module to use with NgDirective #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,57 @@ | |||
| library foo; | |||
There was a problem hiding this comment.
should this be in the example folder ?
There was a problem hiding this comment.
@vicb I plan to delete the whole demo folder. This is just to be able to demo different behavior and till we decide on the approach.
`module` parameter in NgAnnotation (and other annotations that extend it) can be used to publish types. The old `publishTypes` parameter is removed.
mvuksano
added a commit
that referenced
this pull request
Apr 2, 2014
`module` parameter in NgAnnotation (and other annotations that extend it) can be used to publish types. The change is a bit more wordy but it is a lot more powerful. BREAKING CHANGE: `publishTypes` parameter is removed. @ngdirective( publishTypes: [FooInt] ) class Foo extends FooInt { } becomes @ngdirective( module: Foo.module, visibility: NgDirective.LOCAL_VISIBILITY ) class Foo extends FooInt { module() => new Module() ..factory(FooInt, (i) => i.get(Foo), visibility: NgDirective.LOCAL_VISIBILITY) } Closes #779
mvuksano
added a commit
that referenced
this pull request
Apr 2, 2014
`module` parameter in NgAnnotation (and other annotations that extend it) can be used to publish types. The change is a bit more wordy but it is a lot more powerful. BREAKING CHANGE: `publishTypes` parameter is removed. @ngdirective( publishTypes: [FooInt] ) class Foo extends FooInt { } becomes @ngdirective( module: Foo.module, visibility: NgDirective.LOCAL_VISIBILITY ) class Foo extends FooInt { module() => new Module() ..factory(FooInt, (i) => i.get(Foo), visibility: NgDirective.LOCAL_VISIBILITY) } Closes #779
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.