Update the html to match the latest code

[vicb]

see it online @ http://vicb-angulardart.appspot.com/

The first commit has the kind of magics I like: it allows anybody to easily update the code in the html (ie it removes the burden of having to escape the HTML entities).

The second commit is the "real" update. Hopefully I haven't miss anything... anyway it's now much easier for anybody to update.

[kwalrath]

I took a quick look, and noticed that in http://vicb-angulardart.appspot.com/tutorial/03-ch01-creating-your-first-app.html, the "two" script tags (which are 3 in https://angulardart.org/tutorial/03-ch01-creating-your-first-app.html, oops) are just 1:

<script src="packages/shadow_dom/shadow_dom.min.js">

The application/dart and text/javascript tags are missing. So it looks like the new script doesn't deal with <script> tags properly. I'm guessing the </script> tag from the first line ended the <pre>-equivalent section.

Even before I found that it made me a bit nervous to use a <script> tag to mark <pre>-equivalent sections. Is this technique used anywhere else?

[kwalrath]

PS: This is very cool work, and anything that makes it easier to update code samples is a good thing!

[vicb]

about the script technique don't worry, John Resig (the creator of jQuery) was one of the first to promote this: http://ejohn.org/blog/javascript-micro-templating/.

You are right on the fact that <script> tags could not be nested... one solution could be to replace them by [script] - can not think of anything better at the time.

[kwalrath]

We could also leave <script> tags in <pre>. (Either way, we should have a helpful comment for future editors, so they don't break this in the future.)

[kwalrath]

PS: That link does make me feel better about using <script> in this way. :)

[vicb]

We could also leave <script> tags in <pre>

Simple is great! I'll update for this tomorrow (provided we are not using other scripts tags somewhere else)

[kwalrath]

It looks like only ch01 & ch07 have <script> tags in the code snippets.

[vicb]

thanks for the hint, changes commited.

[kwalrath]

Could you update http://vicb-angulardart.appspot.com/ so I can do a visual diff? Thanks!

[vicb]

it's live now

[kwalrath]

In http://vicb-angulardart.appspot.com/tutorial/07-ch05-filter-service.html I happened to notice a couple of code snippets (inside the "Built in filters" section) that don't have enough space above them. E.g., the upper border of the snippet that starts <input id="name-filter" type = "text" is right up against the last line of the previous paragraph. The same is true of the next snippet.

This doesn't happen everywhere, but where it does, it's much more noticeable when the last line of the previous paragraph contains some code font. E.g., I didn't notice this problem above String nameFilterString = ""; but upon closer inspection that snippet has too little space above it.

Perhaps you removed a line above these snippets? Or is there a style change we need to make?

Oh, and... This is new to your version. (I was visually comparing with the old version.)

[vicb]

That was definitely an issue with the markup, it should be fixed now.

[vicb]

thanks for catching it !

[kwalrath]

This example probably needs to stay as a <pre>, since it formats the code (using <strong>, e.g.).

At least, I assume the formatting is intentional...

[vicb]

Nice catch again !

The formatting is indeed intentional.

I would prefer loosing the formatting here over switching back to escaped entities but I'll do whatever your prefer.

[kwalrath]

I don't have strong feelings either way.

-k-

On Wed, Mar 5, 2014 at 8:24 AM, Victor Berchet notifications@github.comwrote:

In app/tutorial/08-ch06-view.html:

@@ -223,81 +223,81 @@

index.html (previous Chapter)

-

-<div recipe-book>

+<script type="template/dart">

Nice catch again !

The formatting is indeed intentional.

I would prefer loosing the formatting here over switching batch to escaped
entities but I'll do whatever your prefer.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/45/files#r10306023
.

[kwalrath]

Once you fix the few things I commented on, this looks great to me.

[vicb]

• removed the <strong> formatting to keep script tags (easier to update),
• fixed <script class="prettyprint">
• changed template/dart to template/code so it could be used everywhere (no only dart)

Will push the commit & update the live version in the coming minutes.

[vicb]

Done and thanks again for the very good feedback !

[kwalrath]

So close!

[vicb]

I think I'm done now :)

[kwalrath]

lgtm! Thanks for making the docs better (and for bearing through the review process :).

[vicb]

Cool! Many thanks for reviewing and catching so many errors !

[kwalrath]

Attention to detail is my gift and curse. :) You're very welcome.