[WIP] update for AngularDart 1.x #64
Conversation
|
/cc @rkirov |
|
For some reason ' (single quote) sometimes renders as Any idea what could be going wong ? |
| see is some code that imports Angular and starts your app. | ||
| <p>That code is minimal because our app is so simple. We start by defining a <code>Greeter</code> | ||
| class. As this class is set to be the root context type, the DI will create an instance of it | ||
| to serve as the context for the application - that is the <code>“name”</code> expression will |
There was a problem hiding this comment.
It looks like the quotation marks around "name" are curly.
There was a problem hiding this comment.
@kwalrath this is to be consistent with the remaining of the chapter (I copy-pasted them)
There was a problem hiding this comment.
I see that now. Oh well. :)
| @@ -245,21 +180,19 @@ to be evaluated:</p> | |||
|
|
|||
| <hr class="spacer" /> | |||
|
|
|||
| <h4 id="how-is-a-component-different-from-a-controller">How is a component | |||
| different from a controller?</h4> | |||
| <h4 id="how-components-work">How components work?</h4> | |||
|
About "For some reason ' (single quote) sometimes renders as ' ie in the first chapter {{ 'foo' + 'bar' }}", perhaps that's because of the {%raw%} formatting? |
|
I don't know the technical content, so I confined myself to looking at language/grammar. I believe you also need to take another look at the flow from page to page, making sure the links and page names are correct. Thanks very much for doing all this work! |
Unfortunately it's not due to |
|
@kwalrath thanks for your very useful review (as usual). I've integrated most of your feedback and verified that the index, next and previous links all work as expected. We are still left with the single quote rendering issue, I'll try to investigate later today. |
|
About the rendering issue: this might be a bug in my local version of jekyll. I hvae tried to isolate the issue but whether it is triggered or not depends on the context of the |
|
I just built the tutorial locally and I don't see any issues with the quotation marks. So I am going to squash and commit the PR. It is long overdue. |
|
Merged. |
@kwalrath could you please review when you are available.
/ref dart-archive/angular.dart.tutorial#131