This repository has been archived by the owner on Nov 9, 2018. It is now read-only.
Add support for HttpHeaders for Dart 2.0 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nex3 I don't know how to address the static analyzer errors because what's caught are missing constants from web_gl. So I don't know if that matters since that's how you had it in the original version. |
|
FYI, these changes are needed in order to bring web_server to Dart 2 and still have it support Dart 1 |
* Generator learns how to process static final variables
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did make a functional change, but I am not sure if a test should be created per the Contributing guide