Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Fixed avoid_unused_constructor_parameters, empty_constructor_bodies #225

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Jan 15, 2021

By fixing generated code
Moved from use of .forEach to for loop to two cases
Misc cleanup

By fixing generated code
Moved from use of .forEach to for loop to two cases
Misc cleanup
@google-cla google-cla bot added the cla: yes label Jan 15, 2021
@kevmoo kevmoo mentioned this pull request Jan 15, 2021
@kevmoo kevmoo requested a review from jonasfj January 18, 2021 21:26
Copy link
Contributor

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forbidding additional properties probably isn't a good idea.

Having a comment to ignore unused argument would be better.

@kevmoo kevmoo merged commit 4a5e77a into master Jan 19, 2021
@kevmoo kevmoo deleted the fix_more_lints branch January 19, 2021 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants