This repository has been archived by the owner on Jan 17, 2024. It is now read-only.
Fix utf8_test to match breaking change to UTF-8 encoding and decoding #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively, we could just remove those two subtests entirely, so the test would be compatible with both versions. |
dcharkes
approved these changes
May 4, 2020
dcharkes
approved these changes
May 4, 2020
dcharkes
pushed a commit
to dart-lang/native
that referenced
this pull request
Jan 16, 2024
…ng change to UTF-8 encoding and decoding (dart-archive/ffi#42) * Delete surrogate-related subtests to be compatible with both behaviors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the expectations of the UTF-8 test to match the recent breaking change to the Dart UTF-8 encoding and decoding described here: dart-lang/sdk#41100
This is necessary to unblock further rolls of the Dart SDK.