This repository has been archived by the owner on Jan 28, 2024. It is now read-only.
Remove ObjC tests that check golden generated code #363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These goldens can only be regenerated on a mac machine, so they make it difficult for people who don't own a mac to contribute. They're also a bit of a nuisance to merge, and we now have good enough coverage with our native_objc_tests that they're not really necessary anymore. The bindings are now generated by native_objc_test/setup.dart, at the same time as the dylibs, and are gitignored.
The objc header_parser tests were removed:
Fixes dart-lang/native#278