This repository has been archived by the owner on Jan 28, 2024. It is now read-only.
Memory management for Blocks #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way I'm cleaning up blocks in this PR is not a hack. The only hack is in the test that checks the refcount. The Dart |
|
Sorry, I misunderstood then. |
brianquinlan
approved these changes
Jul 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a copy/release finalizer for blocks, same as we have for NSObjects. Automatically cleans up the native memory associated with Blocks.
This implements all but the last dot point from dart-lang/native#233. Note that this still leaks the Dart Function objects (see dart-lang/native#233)
Fixes dart-lang/native#233. Filed a separate issue (#428) for cleaning up the Dart Functions, since that's not going to happen any time soon.