This repository has been archived by the owner on Jan 20, 2018. It is now read-only.
add htmlEntryPoint option to transformer #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
force-pushed
the
html-entry-point
branch
2 times, most recently
from
5c3ad15
to
9399106
Compare
| @@ -65,12 +69,23 @@ class InitializeTransformer extends Transformer { | |||
| if (newEntryPoint == null) { | |||
| newEntryPoint = entryPoint.replaceFirst('.dart', '.bootstrap.dart'); | |||
| } | |||
| return new InitializeTransformer(entryPoint, newEntryPoint); | |||
| var htmlEntryPoint = settings.configuration['htmlEntryPoint']; | |||
There was a problem hiding this comment.
we could do the change from 'htmlEntryPoint' -> 'html_entry_point' right away or separately (issue #14)
There was a problem hiding this comment.
I think we can update all of these at once later
|
lgtm |
jakemac53
force-pushed
the
html-entry-point
branch
from
9399106
to
ebcc284
Compare
|
submitting for now, we can revisit the allowing entry points in different folders thing in a later cl if its needed |
jakemac53
added a commit
that referenced
this pull request
Jan 23, 2015
add htmlEntryPoint option to transformer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10