-
Notifications
You must be signed in to change notification settings - Fork 118
Please remove "library" tags from Dart code. #297
Comments
We should hold off on this change until we figure out what the story is for generating library-level API docs. |
The bug for the dartdoc update is here: dart-lang/dartdoc#1082. We might need other fixes, as well... |
We've changed our mind on holding off, btw... |
PR's welcome :) |
for this one the remove has to be done on the source of stagehand or also on the template source ? |
It'll require changing the template source and doing a regen. We've already applied this change to the web-angular template, btw. web-angular/lib/app_component.dart, for example, has no |
not sure this is correct : https://github.com/Kleak/stagehand/tree/remove_library ? |
Go ahead and PR so I can see the diffs. Thanks! |
Only one library directive remains, and it's warranted due to the way library docs get generated. (We could change the example to make it have another directive there, but for now...) |
We no longer recommend that developers write an explicit library tag - a default tag is generated for you using the path/filename and is guaranteed to be unique.
The text was updated successfully, but these errors were encountered: