-
Notifications
You must be signed in to change notification settings - Fork 116
Prepare for v2 release #500
Conversation
@@ -7,12 +7,12 @@ name: stagehand | |||
description: > | |||
A scaffolding generator for your Dart projects. Stagehand helps you get set | |||
up! | |||
version: 2.0.0-alpha-dev | |||
version: 2.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that Dart 2 hasn't reached final, wouldn't it make more sense to not declare this a 2.0.0 yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to – or else pub global activate
won't get it.
No one depends on stagehand as a package. The version doesn't matter much AFAIC
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after rebasing and updating the top-most CHANGELOG entry heading.
Will wait on a 👍 from @kwalrath before I land/publish |
@@ -17,7 +17,7 @@ import 'package:usage/usage_io.dart'; | |||
const String appName = 'stagehand'; | |||
|
|||
// This version must be updated in tandem with the pubspec version. | |||
const String appVersion = '2.0.0-alpha-dev'; | |||
const String appVersion = '2.0.0'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, you don't need to update this manually anymore, the version-check-and-update.sh
script does that for you when you run it. /cc @kwalrath
Cool!
…On Mon, Apr 30, 2018 at 7:46 AM Patrice Chalin ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/src/cli_app.dart
<#500 (comment)>:
> @@ -17,7 +17,7 @@ import 'package:usage/usage_io.dart';
const String appName = 'stagehand';
// This version must be updated in tandem with the pubspec version.
-const String appVersion = '2.0.0-alpha-dev';
+const String appVersion = '2.0.0';
Btw, you don't need to update this manually anymore, the
version-check-and-update.sh script does that for you when you run it. /cc
@kwalrath <https://github.com/kwalrath>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#500 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCilmFv-26DTaflKYX9VL9W9WkSQNlks5ttyPZgaJpZM4Tslrd>
.
|
@kevmoo let me make sure I understand: We can merge this, with no change to IDE behavior, but as soon as we Here's what I think we'll need to coordinate:
Does that sound right? Are we ready for the webdev switch? /cc @matanlurey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to make sure we're ready to switch webdev to Dart 2 before I OK these changes.
Nope. Only IDEs on machines that have at least Dart 2.0.0-dev.51. Everyone else will get the v1 flavor. Since the web templates in v1 assume you have pub serve, this just makes sure folks using dev/be SDKs aren't thrown into a mess. |
@@ -1,4 +1,4 @@ | |||
## 2.0.0-alpha-dev | |||
## 2.0.0 | |||
|
|||
Project and template file changes: | |||
- In `pubspec.yaml` files: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update minimum sdk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also remove the item about enabling the analyzer plugin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The analyzer plugin is still enabled – just you don't need the true
bit any more to do it.
Closes #470