Skip to content
This repository has been archived by the owner on May 31, 2021. It is now read-only.

Prepare for v2 release #500

Merged
merged 7 commits into from
Apr 30, 2018
Merged

Prepare for v2 release #500

merged 7 commits into from
Apr 30, 2018

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Apr 30, 2018

Closes #470

@coveralls
Copy link

coveralls commented Apr 30, 2018

Coverage Status

Coverage remained the same at 83.846% when pulling 43a4453 on release into 3d84b0a on master.

@@ -7,12 +7,12 @@ name: stagehand
description: >
A scaffolding generator for your Dart projects. Stagehand helps you get set
up!
version: 2.0.0-alpha-dev
version: 2.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that Dart 2 hasn't reached final, wouldn't it make more sense to not declare this a 2.0.0 yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to – or else pub global activate won't get it.

No one depends on stagehand as a package. The version doesn't matter much AFAIC

@chalin
Copy link
Contributor

chalin commented Apr 30, 2018

CHANGELOG.md still contains 2.0.0-alpha-dev.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after rebasing and updating the top-most CHANGELOG entry heading.

@kevmoo
Copy link
Contributor Author

kevmoo commented Apr 30, 2018

Will wait on a 👍 from @kwalrath before I land/publish

@@ -17,7 +17,7 @@ import 'package:usage/usage_io.dart';
const String appName = 'stagehand';

// This version must be updated in tandem with the pubspec version.
const String appVersion = '2.0.0-alpha-dev';
const String appVersion = '2.0.0';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, you don't need to update this manually anymore, the version-check-and-update.sh script does that for you when you run it. /cc @kwalrath

@kevmoo
Copy link
Contributor Author

kevmoo commented Apr 30, 2018 via email

@kwalrath
Copy link
Contributor

kwalrath commented Apr 30, 2018

@kevmoo let me make sure I understand: We can merge this, with no change to IDE behavior, but as soon as we pub publish it, EVERY IDE that uses stagehand will switch (on restart) to Dart 2 templates. So publishing this essentially makes Dart 2 the default everywhere, and we'll have to update all of our codelabs and websites accordingly.

Here's what I think we'll need to coordinate:

Does that sound right? Are we ready for the webdev switch?

/cc @matanlurey

Copy link
Contributor

@kwalrath kwalrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to make sure we're ready to switch webdev to Dart 2 before I OK these changes.

@kevmoo
Copy link
Contributor Author

kevmoo commented Apr 30, 2018

as soon as we pub publish it, EVERY IDE that uses stagehand will switch (on restart) to Dart 2 templates

Nope. Only IDEs on machines that have at least Dart 2.0.0-dev.51.

Everyone else will get the v1 flavor. Since the web templates in v1 assume you have pub serve, this just makes sure folks using dev/be SDKs aren't thrown into a mess.

@@ -1,4 +1,4 @@
## 2.0.0-alpha-dev
## 2.0.0

Project and template file changes:
- In `pubspec.yaml` files:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update minimum sdk

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove the item about enabling the analyzer plugin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The analyzer plugin is still enabled – just you don't need the true bit any more to do it.

@kevmoo kevmoo merged commit e03c1df into master Apr 30, 2018
@kevmoo kevmoo deleted the release branch April 30, 2018 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants