Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

chore: move tsd to a devDependency for faster npm install times. #182

Merged
merged 1 commit into from
Jun 4, 2015

Conversation

mprobst
Copy link
Contributor

@mprobst mprobst commented Jun 4, 2015

Fixes #159.

@alexeagle
Copy link
Contributor

I see Igor's comment about this, but I having it as a devDependency broke angular.
#138
which I fixed by moving from devDependency to regular dependency.

I think our only fix here is to write a release script rather than rely on npm to perform the right things in the right order.

@mprobst
Copy link
Contributor Author

mprobst commented Jun 4, 2015

@alexeagle yeah, but that was when we ran tsd reinstall in npm install as a preinstall script, right? Now that we only run it on publish, we should be fine.

@mprobst mprobst merged commit 2f0ef3e into master Jun 4, 2015
@mprobst mprobst deleted the tsd-devdep branch April 21, 2016 16:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants