This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
feat(Array): add support for join #280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -303,6 +303,14 @@ export class FacadeConverter extends base.TranspilerBase { | |||
| }); | |||
| this.emit(')'); | |||
| }, | |||
| 'Array.join': (c: ts.CallExpression, context: ts.Expression) => { | |||
| this.visit(context); | |||
| if (c.arguments.length === 0) { | |||
There was a problem hiding this comment.
nit: I'm ok with writing if (c.arguments.length) { ... }, that's idiomatic enough in my opinion. YMMV.
There was a problem hiding this comment.
right, we don't need to transpile the transpiler, I'll update
|
LGTM with two nits. |
|
landed as b642cf1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mprobst could you please review