This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
feat(filesystem): Apply basePath to relative input TS files and library names #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…even when they are relative. Doesn't change module file name resolution
|
Tested with angular/angular that the code generated with and without the change are the same. |
|
This is okay with me, but it really needs some tests that fail before the change. Can we find the right fixture for a test that reproduces the path problems? I'm imagining a test that lays out a temp directory that looks similar to the google3 scenario, and maybe another that's layed out like angular/angular, and asserts that the program can run on trivially simple inputs. We could do that in a follow-up change so we're not blocked on google3/ts2dart. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't change module file name resolution