Skip to content
This repository has been archived by the owner on Jul 16, 2023. It is now read-only.

fix: additional cases for use-setstate-synchronously #1136

Merged

Conversation

Desdaemon
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #1136 (f42117f) into master (7652d0f) will decrease coverage by 0.03%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
- Coverage   85.51%   85.48%   -0.04%     
==========================================
  Files         347      347              
  Lines        7790     7839      +49     
==========================================
+ Hits         6662     6701      +39     
- Misses       1128     1138      +10     
Impacted Files Coverage Δ
...rules_list/use_setstate_synchronously/visitor.dart 86.00% <78.26%> (-7.11%) ⬇️
...rules_list/use_setstate_synchronously/helpers.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@incendial incendial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@incendial incendial merged commit fa61a59 into dart-code-checker:master Jan 6, 2023
@incendial incendial added this to the 5.5.0 milestone Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] use-setstate-synchronously with switch cases and exception on handling.
2 participants