Skip to content
This repository has been archived by the owner on Jul 16, 2023. It is now read-only.

feat: add avoid-top-level-members-in-tests #920

Merged
merged 2 commits into from
Jul 16, 2022

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix
[X] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Implements: dart-lang/linter#1258

@incendial incendial added type: enhancement New feature or request area-rules labels Jul 13, 2022
@incendial incendial self-assigned this Jul 13, 2022
@github-actions
Copy link

github-actions bot commented Jul 13, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented Jul 13, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 457

  • Total lines of source code: 8002

  • Total classes: 316

  • Average Cyclomatic Number per line of code: 0.35

  • Average Source Lines of Code per method: 6

  • Total tech debt: 1366.0 hours

  • Found issues: 6 ⚠

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@b6a3946). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #920   +/-   ##
=========================================
  Coverage          ?   87.45%           
=========================================
  Files             ?      304           
  Lines             ?     6266           
  Branches          ?        0           
=========================================
  Hits              ?     5480           
  Misses            ?      786           
  Partials          ?        0           
Impacted Files Coverage Δ
...c/analyzers/lint_analyzer/rules/rules_factory.dart 71.42% <ø> (ø)
...n_tests/avoid_top_level_members_in_tests_rule.dart 100.00% <100.00%> (ø)
...list/avoid_top_level_members_in_tests/visitor.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6a3946...2c2955a. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jul 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dkrutskikh dkrutskikh merged commit 9fd3b58 into master Jul 16, 2022
@dkrutskikh dkrutskikh deleted the avoid-top-level-members-in-tests branch July 16, 2022 08:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-rules type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants