Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support formatting #12

Closed
DanTup opened this issue Aug 4, 2016 · 4 comments
Closed

Support formatting #12

DanTup opened this issue Aug 4, 2016 · 4 comments
Assignees
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Aug 4, 2016

No description provided.

@DanTup DanTup added this to the 0.5 milestone Aug 4, 2016
@DanTup DanTup self-assigned this Aug 4, 2016
@DanTup DanTup closed this as completed in ed36561 Aug 4, 2016
@skybrian
Copy link

Is there something special I have to do to make 'format on save' work for Dart?

I have VS Code 1.6.0 and Dart Code 0.11.2, and:

    "editor.formatOnSave": true,
    "files.autoSave": "onWindowChange",

@DanTup
Copy link
Member Author

DanTup commented Oct 11, 2016

@skybrian

I haven't tried this out yet, but does it work if you save explicitly? The release notes have this:

Note: To keep cursors and selections stable, we don't format when saving after delay.

but I'm not really sure what the delay they refer to is. If it works when you explicitly save, then I guess it's that. If that still doesn't work, feel free to raise a case about it not playing nice with formatOnSave and I'll do some investigation.

@skybrian
Copy link

Yeah, I found that confusing too. I think it refers to when "file.autoSave" is set to "afterDelay", which isn't what I selected.

It doesn't format when I explicitly save. I tried setting "file.autoSave" to off and it didn't help. (I haven't seen formatting work at all, actually. When should it be working?)

@DanTup
Copy link
Member Author

DanTup commented Oct 12, 2016

Alt+Shift+F formats (it's the normal Code shortcut). I expected it'd just get invoked on save now, but haven't had chance to review the 1.6 stuff. It also seems that compiles errors etc will cause forgetting to fail, could it that?

Could you raise a new case with the details of what does/doesn't work and I'll try to take a look this week?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants