Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in ConsumerStreamIterator.attachStream() #16

Merged
merged 20 commits into from
May 30, 2020

Conversation

larryaasen
Copy link

Fixed bug in ConsumerStreamIterator.attachStream() where '==' was being used instead of '=', so the _subscription was not reset to null on rebalance. Also, renamed async.dart to consumer_streamiterator.dart which was more appropriate.

Updated code in kafka-0.10 branch to support Dart 2.7 (dart-kafka#14)
…ng used instead of '=', so the _subscription was not reset to null on rebalance. Also, renamed async.dart to consumer_streamiterator.dart which was more appropriate.
Updated Docker images to the latest (dart-kafka#15)
@larryaasen
Copy link
Author

I don't understand why my branch passes on Travis, but not when it is run from here. Travis builds the same branch for both GitHub accounts, both mine passes on this one has one test failure.

Screen Shot 2020-04-25 at 9 10 51 AM

You can see the passing of commit ece25a2 which is my latest commit on this branch.

@larryaasen
Copy link
Author

The consumer and producer seem very stable now, and I have been running them for about 24 hours. I have two processes: one to push out a message every 60 seconds, and the other to consume it.

The tool is setup now to run Kafka 0.10.2.1 dated April 26, 2017 using Docker image ches/kafka:latest. The next step would be to upgrade the tool to use a recent version of Docker. I attempted that but it requires significant image changes, because ches/kafka does not have a recent version of Kafka.

… to larryaasen/kafka, which is Kafka 2.5.0. The image larryaasen/kafka is a fork of ches/kafka that was updated to the latest version of Kafka. Added missing Kafka config offsets.topic.replication.factor=1 which was new in Kafka 0.11.0.
@larryaasen
Copy link
Author

@pulyaevskiy This latest update is using the latest version of Kafka 2.5.0, and passes all 48 tests. Please check this out.

@@ -111,7 +106,7 @@ class ConsumerStreamIterator<K, V>
Object records;
if (_subscription != null) {
_subscription.cancel();
_subscription == null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, good catch! :)

Copy link
Collaborator

@pulyaevskiy pulyaevskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pulyaevskiy pulyaevskiy merged commit 57999d7 into dart-kafka:kafka-0.10 May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants