Skip to content

Commit

Permalink
Update lints deps (#3711)
Browse files Browse the repository at this point in the history
  • Loading branch information
kevmoo committed May 29, 2024
1 parent e67cdd5 commit 4ea16a7
Show file tree
Hide file tree
Showing 55 changed files with 89 additions and 22 deletions.
2 changes: 1 addition & 1 deletion _test/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ dev_dependencies:
build_runner_core: any
build_test: any
build_web_compilers: any
dart_flutter_team_lints: ^2.0.0
dart_flutter_team_lints: ^3.1.0
io: ^1.0.0
path: ^1.8.0
provides_builder:
Expand Down
2 changes: 2 additions & 0 deletions _test/test/build_integration_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// BSD-style license that can be found in the LICENSE file.

@TestOn('vm')
library;

import 'dart:io';

import 'package:build_runner/src/build_script_generate/build_script_generate.dart';
Expand Down
1 change: 1 addition & 0 deletions _test/test/dart2js_integration_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

@TestOn('vm')
@Tags(['integration'])
library;

import 'dart:async';
import 'dart:io';
Expand Down
2 changes: 2 additions & 0 deletions _test/test/doctor_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// BSD-style license that can be found in the LICENSE file.

@TestOn('vm')
library;

import 'package:test/test.dart';

import 'common/utils.dart';
Expand Down
2 changes: 2 additions & 0 deletions _test/test/exception_handling_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// BSD-style license that can be found in the LICENSE file.

@TestOn('vm')
library;

import 'package:test/test.dart';

import 'common/utils.dart';
Expand Down
2 changes: 2 additions & 0 deletions _test/test/generated_script_integration_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// BSD-style license that can be found in the LICENSE file.

@TestOn('vm')
library;

import 'dart:io' show File;

import 'package:test/test.dart';
Expand Down
2 changes: 2 additions & 0 deletions _test/test/hello_world_custom_html_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// BSD-style license that can be found in the LICENSE file.

@TestOn('browser')
library;

import 'dart:html';

import 'package:test/test.dart';
Expand Down
2 changes: 2 additions & 0 deletions _test/test/hello_world_deferred_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// BSD-style license that can be found in the LICENSE file.

@TestOn('browser')
library;

import 'dart:html';

import 'package:_test/app.dart';
Expand Down
2 changes: 2 additions & 0 deletions _test/test/hello_world_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// BSD-style license that can be found in the LICENSE file.

@TestOn('browser')
library;

import 'dart:html';

import 'package:_test/app.dart';
Expand Down
9 changes: 7 additions & 2 deletions _test/test/help_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// BSD-style license that can be found in the LICENSE file.

@TestOn('vm')
library;

import 'dart:async';

import 'package:test/test.dart';
Expand Down Expand Up @@ -53,8 +55,11 @@ Future<void> _testHelpCommand(List<String> args, {String? checkContent}) async {
var result = await asyncResult;
expect(result.exitCode, equals(0),
reason: 'should give a successful exit code');
expect(result.stderr, isEmpty,
reason: 'Should output nothing on stderr',);
expect(
result.stderr,
isEmpty,
reason: 'Should output nothing on stderr',
);
expect(result.stdout, isNot(contains('"Unhandled exception"')),
reason: 'Should not print an unhandled exception');
if (checkContent != null) {
Expand Down
2 changes: 2 additions & 0 deletions _test/test/serve_integration_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// BSD-style license that can be found in the LICENSE file.

@TestOn('vm')
library;

import 'dart:convert';
import 'dart:io'
show
Expand Down
2 changes: 2 additions & 0 deletions _test/test/sub-dir/subdir_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// BSD-style license that can be found in the LICENSE file.

@TestOn('browser')
library;

import 'package:test/test.dart';

import '../hello_world_test.dart' as original;
Expand Down
1 change: 1 addition & 0 deletions _test/test/test_integration_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// BSD-style license that can be found in the LICENSE file.

@TestOn('vm')
library;

import 'package:io/io.dart';
import 'package:path/path.dart' as p;
Expand Down
2 changes: 1 addition & 1 deletion _test_common/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ dependencies:
watcher: ^1.0.0

dev_dependencies:
dart_flutter_team_lints: ^2.0.0
dart_flutter_team_lints: ^3.1.0

dependency_overrides:
build:
Expand Down
7 changes: 0 additions & 7 deletions analysis/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,3 @@ analyzer:
# Common top level directories containing generated files in any package.
- "build/**"
- ".dart_tool/**"

linter:
rules:
# TODO: Remove this once we can use unnamed libraries.
library_annotations: false
# TODO: https://github.com/google/json_serializable.dart/issues/1313
use_string_in_part_of_directives: false
2 changes: 1 addition & 1 deletion analysis/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ publish_to: none
environment:
sdk: ^3.4.0
dev_dependencies:
dart_flutter_team_lints: ^2.0.0
dart_flutter_team_lints: ^3.1.0
2 changes: 2 additions & 0 deletions build/test/asset/id_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
@TestOn('vm')
library;

import 'package:build/build.dart';
import 'package:test/test.dart';

Expand Down
2 changes: 2 additions & 0 deletions build/test/builder/build_step_impl_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
@TestOn('vm')
library;

import 'dart:async';
import 'dart:convert';

Expand Down
2 changes: 2 additions & 0 deletions build/test/generate/run_builder_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
@TestOn('vm')
library;

import 'dart:async';

import 'package:build/build.dart';
Expand Down
2 changes: 2 additions & 0 deletions build/test/resource/resource_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
@TestOn('vm')
library;

import 'dart:async';

import 'package:build/build.dart';
Expand Down
2 changes: 1 addition & 1 deletion build_config/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ dependencies:

dev_dependencies:
build_runner: ^2.0.0
dart_flutter_team_lints: ^2.0.0
dart_flutter_team_lints: ^3.1.0
json_serializable: ^6.0.0
term_glyph: ^1.2.0
test: ^1.16.0
Expand Down
2 changes: 1 addition & 1 deletion build_daemon/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ dev_dependencies:
build_runner: ^2.0.0
# TODO: untangle analyzer dependency
built_value_generator: ^8.1.0
dart_flutter_team_lints: ^2.0.0
dart_flutter_team_lints: ^3.1.0
mockito: ^5.0.0
test: ^1.25.5
test_descriptor: ^2.0.0
Expand Down
2 changes: 2 additions & 0 deletions build_daemon/test/daemon_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
@OnPlatform({
'windows': Skip('Directories cant be deleted while processes are still open')
})
library;

import 'dart:async';
import 'dart:convert';
import 'dart:io';
Expand Down
2 changes: 2 additions & 0 deletions build_daemon/test/server_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
@OnPlatform({
'windows': Skip('Directories cant be deleted while processes are still open')
})
library;

import 'dart:async';
import 'dart:convert';

Expand Down
1 change: 1 addition & 0 deletions build_modules/test/build_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

@Tags(['presubmit-only'])
@OnPlatform({'windows': Skip('line endings are different')})
library;

import 'dart:convert';
import 'dart:io';
Expand Down
1 change: 1 addition & 0 deletions build_modules/test/fixtures/a/lib/a_part_library_name.dart
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
// ignore: use_string_in_part_of_directives
part of a_imports_b_no_cycle;
2 changes: 1 addition & 1 deletion build_resolvers/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ dependencies:

dev_dependencies:
build_test: ^2.0.0
dart_flutter_team_lints: ^2.0.0
dart_flutter_team_lints: ^3.1.0
test: ^1.16.0

topics:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
@Timeout.factor(4)
library;

import 'package:_test_common/descriptors.dart';
import 'package:_test_common/sdk.dart';
import 'package:test/test.dart';
Expand Down
2 changes: 2 additions & 0 deletions build_runner/test/build_script_generate/experiments_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

@Tags(['experiments'])
@TestOn('vm')
library;

import 'package:build_runner/build_script_generate.dart';
import 'package:logging/logging.dart';
import 'package:test/test.dart';
Expand Down
1 change: 1 addition & 0 deletions build_runner/test/daemon/daemon_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// BSD-style license that can be found in the LICENSE file.

@Tags(['integration'])
library;

import 'dart:async';
import 'dart:convert';
Expand Down
2 changes: 2 additions & 0 deletions build_runner/test/entrypoint/clean_integration_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// BSD-style license that can be found in the LICENSE file.

@Tags(['integration'])
library;

import 'package:_test_common/common.dart';
import 'package:test/test.dart';
import 'package:test_descriptor/test_descriptor.dart' as d;
Expand Down
1 change: 1 addition & 0 deletions build_runner/test/entrypoint/run_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// BSD-style license that can be found in the LICENSE file.

@Tags(['integration'])
library;

import 'dart:async';
import 'dart:convert';
Expand Down
2 changes: 2 additions & 0 deletions build_runner/test/generate/build_integration_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// BSD-style license that can be found in the LICENSE file.

@Tags(['integration'])
library;

import 'dart:async';
import 'dart:convert';
import 'dart:io';
Expand Down
2 changes: 2 additions & 0 deletions build_runner/test/generate/run_script_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// BSD-style license that can be found in the LICENSE file.

@Tags(['integration'])
library;

import 'dart:convert';

import 'package:_test_common/common.dart';
Expand Down
2 changes: 2 additions & 0 deletions build_runner/test/generate/serve_integration_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// BSD-style license that can be found in the LICENSE file.

@Tags(['integration'])
library;

import 'dart:async';
import 'dart:convert';
import 'dart:io';
Expand Down
2 changes: 2 additions & 0 deletions build_runner/test/generate/watch_integration_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// BSD-style license that can be found in the LICENSE file.

@Tags(['integration'])
library;

import 'dart:async';
import 'dart:convert';
import 'dart:io';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// BSD-style license that can be found in the LICENSE file.

@Tags(['integration'])
library;

import 'dart:async';
import 'dart:io';
Expand Down
1 change: 1 addition & 0 deletions build_runner/test/integration_tests/errors_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// BSD-style license that can be found in the LICENSE file.

@Tags(['integration'])
library;

import 'package:build_test/build_test.dart';
import 'package:test/test.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// BSD-style license that can be found in the LICENSE file.

@Tags(['integration'])
library;

import 'dart:async';

Expand Down
2 changes: 2 additions & 0 deletions build_runner/test/integration_tests/symlinks_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// BSD-style license that can be found in the LICENSE file.

@Tags(['integration'])
library;

import 'dart:async';
import 'dart:io';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// BSD-style license that can be found in the LICENSE file.

@Tags(['integration'])
library;

import 'package:build_test/build_test.dart';
import 'package:io/io.dart' show ExitCode;
import 'package:test/test.dart';
Expand Down
2 changes: 2 additions & 0 deletions build_runner/test/server/serve_integration_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// BSD-style license that can be found in the LICENSE file.

@Tags(['integration'])
library;

import 'dart:async';
import 'dart:convert';
import 'dart:io';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// BSD-style license that can be found in the LICENSE file.

@experimental
library build_runner.src.generate.performance_tracker;
library;

import 'dart:async';

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 4ea16a7

Please sign in to comment.