dont rethrow file watcher errors, just log them at severe level (#3165)

Fixes #3150
dart-lang · Aug 5, 2021 · 622c659 · 622c659
1 parent 382da20
commit 622c659
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/build_runner/CHANGELOG.md b/build_runner/CHANGELOG.md
@@ -1,3 +1,9 @@
+## 2.1.1-dev
+
+- Don't rethrow file watcher errors - instead log at severe level and continue
+  going. The file watcher implementation should restart automatically as of
+  package:watcher version `0.9.7+13`.
+
 ## 2.1.0
 
 - Add `--log-requests` flag to build daemon.

diff --git a/build_runner/lib/src/watcher/graph_watcher.dart b/build_runner/lib/src/watcher/graph_watcher.dart
@@ -59,9 +59,9 @@ class PackageGraphWatcher {
                   'Error from directory watcher for package:${w.node.name}\n\n'
                   'If you see this consistently then it is recommended that '
                   'you enable the polling file watcher with '
-                  '--use-polling-watcher.');
-              // ignore: only_throw_errors
-              throw e;
+                  '--use-polling-watcher.',
+                  e,
+                  s);
             }))
         .toList();
     // Asynchronously complete the `_readyCompleter` once all the watchers

diff --git a/build_runner/pubspec.yaml b/build_runner/pubspec.yaml
@@ -1,5 +1,5 @@
 name: build_runner
-version: 2.1.0
+version: 2.1.1-dev
 description: A build system for Dart code generation and modular compilation.
 repository: https://github.com/dart-lang/build/tree/master/build_runner