Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_config errors test text has changed on 3.0 dev #3428

Closed
jakemac53 opened this issue Dec 16, 2022 · 1 comment · Fixed by #3568
Closed

build_config errors test text has changed on 3.0 dev #3428

jakemac53 opened this issue Dec 16, 2022 · 1 comment · Fixed by #3568

Comments

@jakemac53
Copy link
Contributor

The test is test/errors_test.dart: for null exclude globs, error looks like below. Skipping for now, ideally we just fix the message and unskip.

 ACTUAL
  r'''
  line 7, column 11 of build.yaml: Unsupported value for "exclude". type 'Null' is not a subtype of type 'String' of ' in type cast'
    ╷
  7 │           -
    │           ^
    ╵'''
  Expected: throws <Instance of 'ArgumentError'> with `message`: 'line 7, column 11 of build.yaml: Unsupported value for "exclude". type \'Null\' is not a subtype of type \'String\' in type cast\n'
              '  ╷\n'
              '7 │           -\n'
              '  │           ^\n'
              '  ╵'
    Actual: <Closure: () => BuildConfig>
     Which: threw ArgumentError:<Invalid argument(s): line 7, column 11 of build.yaml: Unsupported value for "exclude". type 'Null' is not a subtype of type 'String' of ' in type cast'
                    ╷
                  7 │           -
                    │           ^
                    ╵>
@jakemac53
Copy link
Contributor Author

Filed dart-lang/sdk#50756

auto-submit bot pushed a commit that referenced this issue Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant