migrate off of library.parts #3342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like links to direct source files on github are not working, causing the markdown checker to fail. |
This reverts commit 7e9d2bd.
jakemac53
commented
Jul 25, 2022
| @@ -256,7 +256,7 @@ class AnalyzerResolver implements ReleasableResolver { | |||
| Future<List<ErrorsResult>> _syntacticErrorsFor(LibraryElement element) async { | |||
| final existingElements = [ | |||
| element, | |||
| for (final part in element.parts) | |||
| for (final part in element.parts2) | |||
There was a problem hiding this comment.
It looks like this no longer gives the actual part source, but just the library source.
How can I get the part source? It seems hidden now.
There was a problem hiding this comment.
Should I cast these to a DirectiveUriWithSource? Or just do a check for that type?
There was a problem hiding this comment.
Ok yeah that looks like the fix, I updated to check for the DirectiveUriWithSource type and then use the source from that. LMK if I should do something else.
scheglov
reviewed
Jul 25, 2022
scheglov
approved these changes
Jul 25, 2022
scheglov
reviewed
Jul 25, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.