Introduce applicationConfigHome #66
Conversation
| /// [XDG Base Directory Specification][1] on Linux and [File System Basics][2] | ||
| /// on Mac OS. | ||
| /// | ||
| /// Throws if `%APPDATA%` or `$HOME` is undefined. |
There was a problem hiding this comment.
| /// Throws if `%APPDATA%` or `$HOME` is undefined. | |
| /// Throws if `%APPDATA%` or `$HOME` is needed but undefined. |
| /// * `$HOME/.config/<productName>` otherwise. | ||
| /// | ||
| /// This aims follows best practices for each platform, honoring the | ||
| /// [XDG Base Directory Specification][1] on Linux and [File System Basics][2] |
There was a problem hiding this comment.
Do we have documentation for the windows convention?
There was a problem hiding this comment.
I tried, I can't find any canonical source on MSDN... The closes I got was:
https://docs.microsoft.com/en-us/windows/deployment/usmt/usmt-recognized-environment-variables
But I have no idea what that page actually pertains to.. It looks like it says:
When using the XML files MigDocs.xml, MigApp.xml, and MigUser.xml, you can use environment variables to identify folders that may be different on different computers
So it pertains to people writing such XML files.. and not as general documentation of the Windows environment variables. Or at-least this is not clear to me 🙈
There is also references to Windows File System Namespace Usage Guidelines floating around, but again I can't find updated documentation from original source.
Who knows... maybe it's hidden behind an MSDN subscription? Or maybe it's just so widely known and there is so many search hits that finding the canonical documentation is very hard.
We could use wikipedia:
- https://en.wikipedia.org/wiki/Environment_variable#Windows
- https://en.wikipedia.org/wiki/Special_folder
I just gave up 🤣
|
|
||
| group('applicationConfigHome', () { | ||
| test('returns a string', () { | ||
| expect(applicationConfigHome('dart'), isA<String>()); |
There was a problem hiding this comment.
Hmm - this is hard to test - but it seems we should be able to do better.
Could we at least confirm that the string ends with '${separator}dart'
We started moving
dart pubconfiguration files here, see: dart-lang/pub#2999 (comment)I figured this logic might live in
cli_utils, then it's easy to use indartdev, etc...Should also make it easy to fix dart-lang/sdk#41560