-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failures on [co19] Roll co19_2 to 1c2e425f461bfae7de6db7014fc44a58fc72b4a8 #1090
Comments
It looks like this failure is caused by running the analyzer with So, presumably, we should just stop passing that option to dartanalyzer when the |
Makes sense, I'll give it a try here: |
dart-lang/co19#1090 TEST=Standard tryjobs, all changes are in test code only. Change-Id: Ie73174447ab165827335652cf035f85b7510ab55 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201564 Commit-Queue: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Bob Nystrom <rnystrom@google.com>
@athomas @eernstg With the change above in the SDK the test is still failing. On the fresh build of the SDK it produces
As you can see there is no The problem is that this test contains |
It's the analyzer, and we should have an SDK issue about this behavior, with
|
I created this one: dart-lang/sdk#46273. |
With the dart-lang/sdk#46273 fixed there is no more this failure any longer on the fresh SDK build. Thank you |
There are new test failures on [co19] Roll co19_2 to 1c2e425f461bfae7de6db7014fc44a58fc72b4a8.
The tests
are failing on configurations
The text was updated successfully, but these errors were encountered: