Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expectation needs adjustment in tearing_off_from_typedef_A03_t07.dart #1224

Closed
eernstg opened this issue Oct 14, 2021 · 1 comment
Closed
Assignees

Comments

@eernstg
Copy link
Member

eernstg commented Oct 14, 2021

Line 28 in https://github.com/dart-lang/co19/blob/master/LanguageFeatures/Constructor-tear-offs/tearing_off_from_typedef_A03_t07.dart expects v1 and v3 to be identical, but it should be adjusted to expect the opposite, just like the constant case in line 35.

@sgrekhov
Copy link
Contributor

@eernstg thank you! Please see dart-lang/sdk#47462

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 26, 2021
2021-10-25 sgrekhov@unipro.ru dart-lang/co19#1207. More Enhanced enums tests added
2021-10-25 sgrekhov@unipro.ru dart-lang/co19#1207. More Enhanced enums semantics tests added
2021-10-21 sgrekhov@unipro.ru dart-lang/co19#1207. More Enhanced enums semantics tests added
2021-10-20 sgrekhov@unipro.ru dart-lang/co19#1207. Enhanced enums semantics tests fixed and new added
2021-10-20 sgrekhov@unipro.ru dart-lang/co19#1207. Enhanced enums semsntics tests added
2021-10-20 asashour@yahoo.com Fix typo (dart-lang/co19#1227)
2021-10-19 sgrekhov@unipro.ru dart-lang/co19#1207. More enhanced enums tests added
2021-10-19 irina.arkhipets@gmail.com More fix for dart-lang/co19#1094: Missing Issue tag added (47496).
2021-10-19 irina.arkhipets@gmail.com More fix for dart-lang/co19#1094: Test updated.
2021-10-18 sgrekhov@unipro.ru dart-lang/co19#1207. More enhanced enums tests added
2021-10-18 irina.arkhipets@gmail.com More fix for dart-lang/co19#1094: Test updated to expect current dart behavior, Issue tag added.
2021-10-15 sgrekhov@unipro.ru Fixes dart-lang/co19#1225. Remove check for identity of 0/0 and nan
2021-10-15 sgrekhov@unipro.ru dart-lang/co19#1207. More Enhanced Enums tests added
2021-10-14 sgrekhov@unipro.ru dart-lang/co19#1223. Equality of extension tear-offs is not specified
2021-10-14 sgrekhov@unipro.ru Fixes dart-lang/co19#1224. Don't expect not identical tear-offs to be identical

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I63a11f54c383ca8d90bbdea97bcf65c9ca9e436d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218120
Reviewed-by: William Hesse <whesse@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants