Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests for yield/yield* in async* functions and await for loops. #1363

Closed
sgrekhov opened this issue Jul 12, 2022 · 0 comments
Closed

Update tests for yield/yield* in async* functions and await for loops. #1363

sgrekhov opened this issue Jul 12, 2022 · 0 comments
Assignees
@sgrekhov

Comments

@sgrekhov
Copy link
Contributor

Update existing co19 tests according to the new feature specification
@sgrekhov sgrekhov self-assigned this Jul 12, 2022
sgrekhov pushed a commit to sgrekhov/co19 that referenced this issue Jul 13, 2022
dart-lang#1363. Tests for checking cancelling subscription for yield …
16551e0 
…and yield* added.
sgrekhov pushed a commit to sgrekhov/co19 that referenced this issue Jul 13, 2022
dart-lang#1363. Tests for yield and yield* updated to the current spe…
f9b3e93 
…c. Part 1
sgrekhov pushed a commit to sgrekhov/co19 that referenced this issue Jul 14, 2022
dart-lang#1363. Tests for yield updated to the current specification
ceeea68
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 14, 2022
@sgrekhov
dart-lang#1363. Tests for yield updated to the current specification
7ce3da8
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 15, 2022
@sgrekhov
dart-lang#1363. Tests for yield fixed and updated to the current spec…
2dcf529 
…ification
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 18, 2022
@sgrekhov
dart-lang#1363. Tests for yield fixed and updated to the current spec…
612e8b4 
…ification
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 18, 2022
@sgrekhov
dart-lang#1363. Tests for yield each refactored and new one added
47711a0
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 19, 2022
@sgrekhov
dart-lang#1363. Typo fixed, completer added to avoid flakyness
a6c1a66
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 20, 2022
@sgrekhov
dart-lang#1363. New tests for yield each added
8a175c1
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 20, 2022
@sgrekhov
dart-lang#1363. Yield each tests updated and new ones added
79ff418
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 21, 2022
@sgrekhov
dart-lang#1363. Async for-in tests updated and new ones added
b4e3f3c
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 21, 2022
@sgrekhov
dart-lang#1363. Missed asyncStart()/asyncEnd() added
1d72fa1
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 21, 2022
@sgrekhov
dart-lang#1363. Missed test for resume() with no pause() added
d23f79f
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 22, 2022
@sgrekhov
dart-lang#1363. Async for-in tests refactored, fixed and new ones added
ff2067c
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 25, 2022
@sgrekhov
dart-lang#1363. Changes according to the review notes
e62d192
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 25, 2022
@sgrekhov
dart-lang#1363. Changes according to the review notes. Some delays re…
f3038a1 
…placed by `await null;`
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 25, 2022
@sgrekhov
dart-lang#1363. Some delays replaced by await null;
c109404
eernstg pushed a commit that referenced this issue Jul 25, 2022
@sgrekhov
#1363. Tests for yield updated to the current specification (#1370)
acc78f9 
Authored by @sgrekhov.

Tests for yield fixed and updated to the current specification. Completer added to avoid flakiness. Missing asyncStart()/asyncEnd() added. Some delays replaced by `await null;`.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 25, 2022
@sgrekhov
dart-lang#1363. More async for-in tests added
8e05690
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 27, 2022
@sgrekhov
Fixes dart-lang#1363. Yield each tests rewritten to not to rely on de…
54c81cb 
…lays but use a completer
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 27, 2022
@sgrekhov
dart-lang#1363. Excessive delays removed
3dbe9a4
eernstg pushed a commit that referenced this issue Jul 27, 2022
@sgrekhov
#1363. Yield each tests updated to the current specification (#1374)
4f9a06e 
Authored by @sgrekhov.

Yield-each tests updated and new ones added; some delays replaced by `await null;`; do not to rely on delays, but use a completer (to avoid having flakiness during high loads, and in general to avoid depending on scheduling order and timing).
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 28, 2022
@sgrekhov
dart-lang#1363. Some delays removed or reduced
1a1a65e
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 28, 2022
@sgrekhov
dart-lang#1363. Minor changes according to the review notes
bf4c337
eernstg pushed a commit that referenced this issue Jul 29, 2022
@sgrekhov
#1363 Async for-in test updated according to the current specificat…
7ba6cc3 
…ion (#1379)

Authored by @sgrekhov.

Async for-in tests refactored, fixed and new ones added. Excessive delays removed.
eernstg pushed a commit that referenced this issue Jul 29, 2022
@sgrekhov
#1363. Some delays removed or reduced (#1380)
19e5e9d 
Authored by @sgrekhov. Async scheduling was guided by some delays, those are now shorter or replaced by `await null`.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Aug 4, 2022
@sgrekhov
dart-lang#1363. Tests for yield updated to the current specification (d…
c3a519a 
…art-lang#1370)

Authored by @sgrekhov.

Tests for yield fixed and updated to the current specification. Completer added to avoid flakiness. Missing asyncStart()/asyncEnd() added. Some delays replaced by `await null;`.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Aug 4, 2022
@sgrekhov
dart-lang#1363. Yield each tests updated to the current specification (…
fe812bf 
…dart-lang#1374)

Authored by @sgrekhov.

Yield-each tests updated and new ones added; some delays replaced by `await null;`; do not to rely on delays, but use a completer (to avoid having flakiness during high loads, and in general to avoid depending on scheduling order and timing).
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Aug 4, 2022
@sgrekhov
dart-lang#1363. Some delays removed or reduced (dart-lang#1380)
f38054b 
Authored by @sgrekhov. Async scheduling was guided by some delays, those are now shorter or replaced by `await null`.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Aug 10, 2022
@sgrekhov
dart-lang#1363. Minor code improvement
c64c402
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Aug 11, 2022
@athomas
[co19] Roll co19 to b572e42fbbfe89644236601f93cb982f23f4d7f1
87fc791 
2022-08-04 sgrekhov22@gmail.com dart-lang/co19#993. FFI tests refactored and improved (dart-lang/co19#1387)
2022-08-04 sgrekhov22@gmail.com dart-lang/co19#993. [FFI] Missed tests added for some new types (dart-lang/co19#1386)
2022-08-03 sgrekhov22@gmail.com Fixes dart-lang/co19#1129. Don't expect any proxy routine in case of DIRECT connection (dart-lang/co19#1383)
2022-08-03 sgrekhov22@gmail.com dart-lang/co19#993. [FFI] Missed tests added for some new types (dart-lang/co19#1384)
2022-07-29 sgrekhov22@gmail.com dart-lang/co19#673. IFrame tests that don't actually test IFrame removed (dart-lang/co19#1382)
2022-07-29 sgrekhov22@gmail.com dart-lang/co19#1363. Some delays removed or reduced (dart-lang/co19#1380)
2022-07-29 sgrekhov22@gmail.com dart-lang/co19#1363 Async `for-in` test updated according to the current specification (dart-lang/co19#1379)
2022-07-27 sgrekhov22@gmail.com dart-lang/co19#1363. Yield each tests updated to the current specification (dart-lang/co19#1374)
2022-07-27 sgrekhov22@gmail.com Fixes dart-lang/co19#1375. Add test for final variable in a for-in loop (dart-lang/co19#1378)
2022-07-25 sgrekhov22@gmail.com dart-lang/co19#1363. Tests for yield updated to the current specification (dart-lang/co19#1370)

Change-Id: Ie92f4b2157284777177012320883247411e214fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254140
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgrekhov