New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibTest/io/RawDatagramSocket/timeout_A02_t01.dart should be made more robust #170
Comments
Issue dart-lang/co19#170 Issue dart-lang/co19#171 Change-Id: Ida6c7c97c43164573e368c96ccc361a311cc7f51 Reviewed-on: https://dart-review.googlesource.com/c/79045 Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com> Auto-Submit: Martin Kustermann <kustermann@google.com>
Same issue with I think all tests in |
… flaky TBR=kustermann@google.com Bug: dart-lang/co19#170 Change-Id: I1dd2fb67c4e5574499d5b0e4221c848acd810fe9 Reviewed-on: https://dart-review.googlesource.com/c/79215 Reviewed-by: Vyacheslav Egorov <vegorov@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
I think RawDatagramSocket/any_A03_t01 is also suffering from the same issue. |
TBR=kustermann@google.com Bug: dart-lang/co19#170 Change-Id: I39a11ec752d49e2e87dbcc8caedbc2851c4e7e8b Reviewed-on: https://dart-review.googlesource.com/c/79342 Reviewed-by: Vyacheslav Egorov <vegorov@google.com> Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
LibTest/io/RawDatagramSocket/timeout_A06_t01 still failing (sometimes) |
Similarly any_A01_t02 from the same folder has failed too. FAILED: dartk-vm release_x64 co19_2/LibTest/io/RawDatagramSocket/any_A01_t02
Expected: Pass
Actual: RuntimeError
--- Command "vm" (took 547ms):
DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart --sync-async --ignore-unrecognized-flags --packages=/b/s/w/ir/.packages /b/s/w/ir/tests/co19_2/src/LibTest/io/RawDatagramSocket/any_A01_t02.dart
exit code:
255
stdout:
unittest-suite-wait-for-done
stderr:
Unhandled exception:
Expect.equals(expected: , actual: ) fails.
#0 _fail (file:///b/s/w/ir/tests/co19_2/src/Utils/expect.dart:21:5)
#1 Expect.equals (file:///b/s/w/ir/tests/co19_2/src/Utils/expect_common.dart:30:5)
#2 check... (file:///b/s/w/ir/tests/co19_2/src/LibTest/io/RawDatagramSocket/any_A01_t02.dart:51:16)
#3 _RootZone.runUnary (dart:async/zone.dart:1379:54)
#4 _FutureListener.handleValue (dart:async/future_impl.dart:129:18)
#5 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:642:45)
#6 Future._propagateToListeners (dart:async/future_impl.dart:671:32)
#7 Future._complete (dart:async/future_impl.dart:476:7)
#8 Stream.any. (dart:async/stream.dart:887:18)
#9 _RootZone.runGuarded (dart:async/zone.dart:1302:10)
#10 _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:389:13)
#11 _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:399:15)
#12 _BufferingStreamSubscription._close (dart:async/stream_impl.dart:283:7)
#13 _SyncStreamController._sendDone (dart:async/stream_controller.dart:771:19)
#14 _StreamController._closeUnchecked (dart:async/stream_controller.dart:628:7)
#15 _StreamController.close (dart:async/stream_controller.dart:621:5)
#16 new _RawDatagramSocket. (dart:io/runtime/binsocket_patch.dart:1816:23)
#17 _NativeSocket.multiplex (dart:io/runtime/binsocket_patch.dart:899:39)
#18 _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:171:12)
--- Re-run this test:
python tools/test.py -m release -n dartk-linux-release-x64 co19_2/LibTest/io/RawDatagramSocket/any_A01_t02 I am going to mark the test as flaky again. |
TBR=kustermann@google.com Bug: dart-lang/co19#170 Change-Id: I55c1fa15c886f9e31203499a3fba8991938ddd36 Reviewed-on: https://dart-review.googlesource.com/c/80665 Reviewed-by: Vyacheslav Egorov <vegorov@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Similarly I will mark these tests as flaky. FAILED: dartk-vm debug_ia32 co19_2/LibTest/io/RawDatagramSocket/distinct_A01_t05
Expected: Pass
Actual: RuntimeError
--- Command "vm" (took 06.000112s):
DART_CONFIGURATION=DebugIA32 out/DebugIA32/dart --no-background-compilation --sync-async --ignore-unrecognized-flags --packages=/b/s/w/ir/.packages /b/s/w/ir/tests/co19_2/src/LibTest/io/RawDatagramSocket/distinct_A01_t05.dart
exit code:
255
stdout:
unittest-suite-wait-for-done
stderr:
Unhandled exception:
Expect.equals(expected: <3>, actual: <8>) fails.
#0 _fail (file:///b/s/w/ir/tests/co19_2/src/Utils/expect.dart:21:5)
#1 Expect.equals (file:///b/s/w/ir/tests/co19_2/src/Utils/expect_common.dart:30:5)
#2 main... (file:///b/s/w/ir/tests/co19_2/src/LibTest/io/RawDatagramSocket/distinct_A01_t05.dart:61:16)
#3 _RootZone.runGuarded (dart:async/zone.dart:1302:10)
#4 _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:389:13)
#5 _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:399:15)
#6 _BufferingStreamSubscription._close (dart:async/stream_impl.dart:283:7)
#7 _ForwardingStream._handleDone (dart:async/stream_pipe.dart:106:10)
#8 _ForwardingStreamSubscription._handleDone (dart:async/stream_pipe.dart:172:13)
#9 _RootZone.runGuarded (dart:async/zone.dart:1302:10)
#10 _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:389:13)
#11 _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:399:15)
#12 _BufferingStreamSubscription._close (dart:async/stream_impl.dart:283:7)
#13 _SyncBroadcastStreamController._sendDone. (dart:async/broadcast_stream_controller.dart:401:22)
#14 _BroadcastStreamController._forEachListener (dart:async/broadcast_stream_controller.dart:328:15)
#15 _SyncBroadcastStreamController._sendDone (dart:async/broadcast_stream_controller.dart:400:7)
#16 _BroadcastStreamController.close (dart:async/broadcast_stream_controller.dart:276:5)
#17 _AsBroadcastStreamController.close (dart:async/broadcast_stream_controller.dart:504:27)
#18 _RootZone.runGuarded (dart:async/zone.dart:1302:10)
#19 _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:389:13)
#20 _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:399:15)
#21 _BufferingStreamSubscription._close (dart:async/stream_impl.dart:283:7)
#22 _SyncStreamController._sendDone (dart:async/stream_controller.dart:771:19)
#23 _StreamController._closeUnchecked (dart:async/stream_controller.dart:628:7)
#24 _StreamController.close (dart:async/stream_controller.dart:621:5)
#25 new _RawDatagramSocket. (dart:io/runtime/binsocket_patch.dart:1816:23)
#26 _NativeSocket.multiplex (dart:io/runtime/binsocket_patch.dart:899:39)
#27 _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:171:12)
--- Re-run this test:
python tools/test.py -m debug -a ia32 -n dartk-linux-debug-ia32 co19_2/LibTest/io/RawDatagramSocket/distinct_A01_t05 FAILED: dartk-vm debug_ia32 co19_2/LibTest/io/RawDatagramSocket/timeout_A02_t01
Expected: Pass
Actual: RuntimeError
--- Command "vm" (took 08.000650s):
DART_CONFIGURATION=DebugIA32 out/DebugIA32/dart --no-background-compilation --sync-async --ignore-unrecognized-flags --packages=/b/s/w/ir/.packages /b/s/w/ir/tests/co19_2/src/LibTest/io/RawDatagramSocket/timeout_A02_t01.dart
exit code:
255
stdout:
unittest-suite-wait-for-done
stderr:
Unhandled exception:
Expect.isNull(actual: ) fails.
#0 _fail (file:///b/s/w/ir/tests/co19_2/src/Utils/expect.dart:21:5)
#1 Expect.isNull (file:///b/s/w/ir/tests/co19_2/src/Utils/expect_common.dart:57:5)
#2 check... (file:///b/s/w/ir/tests/co19_2/src/LibTest/io/RawDatagramSocket/timeout_A02_t01.dart:65:16)
#3 Timer._createTimer. (dart:async/runtime/libtimer_patch.dart:21:15)
#4 _Timer._runTimers (dart:isolate/runtime/libtimer_impl.dart:382:19)
#5 _Timer._handleMessage (dart:isolate/runtime/libtimer_impl.dart:416:5)
#6 _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:171:12)
--- Re-run this test:
python tools/test.py -m debug -a ia32 -n dartk-linux-debug-ia32 co19_2/LibTest/io/RawDatagramSocket/timeout_A02_t01 FAILED: dartk-vm debug_ia32 co19_2/LibTest/io/RawDatagramSocket/asBroadcastStream_A01_t02
Expected: Pass
Actual: Timeout
--- Command "vm" (took 02:00.000218s):
DART_CONFIGURATION=DebugIA32 out/DebugIA32/dart --no-background-compilation --sync-async --ignore-unrecognized-flags --packages=/b/s/w/ir/.packages /b/s/w/ir/tests/co19_2/src/LibTest/io/RawDatagramSocket/asBroadcastStream_A01_t02.dart
exit code:
-15
diagnostics:
Process list including children: [17686]
Trying to capture stack trace for pid 17686
PID 17686 - process
TID 17686:
#0 0xf7764cd9 __kernel_vsyscall
#1 0xf7735d0b pthread_cond_wait@@GLIBC_2.3.2
#2 0x011b12dd dart::Monitor::WaitMicros(long long)
#3 0x011b11f7 dart::Monitor::Wait(long long)
#4 0x014137fd Dart_RunLoop
#5 0x00e5296b dart::bin::RunMainIsolate(char const*, dart::bin::CommandLineOptions*)
#6 0x00e535bf dart::bin::main(int, char**)
#7 0x00e53fa4 main
#8 0xf743eaf3 __libc_start_main
#9 0x00e52021 _start
TID 17687:
#0 0xf7764cd9 __kernel_vsyscall
#1 0xf7513ee6 epoll_wait
#2 0x00e5c3bd dart::bin::EventHandlerImplementation::Poll(unsigned int)
#3 0x00e861f4 dart::bin::ThreadStart(void*)
#4 0xf7731f72 start_thread
#5 0xf751343e __clone
eu-stack: dwfl_thread_getframes tid 17686 at 0xe52020 in /b/s/w/ir/out/DebugIA32/dart: no matching address range
stdout:
unittest-suite-wait-for-done
--- Re-run this test:
python tools/test.py -m debug -a ia32 -n dartk-linux-debug-ia32 co19_2/LibTest/io/RawDatagramSocket/asBroadcastStream_A01_t02 |
Issue: dart-lang/co19#170 Change-Id: Ib0a80d12fab5f968e26a28988ef8d6c0973b48d1 Reviewed-on: https://dart-review.googlesource.com/c/80800 Commit-Queue: Daco Harkes <dacoharkes@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
More flakiness, also FAILED: dartk-vm product_x64 co19_2/LibTest/io/RawDatagramSocket/lastWhere_A01_t02
Expected: Pass
Actual: RuntimeError
--- Command "vm" (took 751ms):
DART_CONFIGURATION=ProductX64 out/ProductX64/dart --sync-async --ignore-unrecognized-flags --packages=/b/s/w/ir/.packages /b/s/w/ir/tests/co19_2/src/LibTest/io/RawDatagramSocket/lastWhere_A01_t02.dart
exit code:
255
stdout:
unittest-suite-wait-for-done
stderr:
Unhandled exception:
Expect.equals(expected: <4>, actual: <6>) fails.
#0 _fail (file:///b/s/w/ir/tests/co19_2/src/Utils/expect.dart:21:5)
#1 Expect.equals (file:///b/s/w/ir/tests/co19_2/src/Utils/expect_common.dart:30:5)
#2 check.<anonymous closure>.<anonymous closure>.<anonymous closure> (file:///b/s/w/ir/tests/co19_2/src/LibTest/io/RawDatagramSocket/lastWhere_A01_t02.dart:55:16)
#3 _RootZone.runGuarded (dart:async/zone.dart:1302:10)
#4 _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:389:13)
#5 _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:399:15)
#6 _BufferingStreamSubscription._close (dart:async/stream_impl.dart:283:7)
#7 _SyncBroadcastStreamController._sendDone.<anonymous closure> (dart:async/broadcast_stream_controller.dart:401:22)
#8 _BroadcastStreamController._forEachListener (dart:async/broadcast_stream_controller.dart:328:15)
#9 _SyncBroadcastStreamController._sendDone (dart:async/broadcast_stream_controller.dart:400:7)
#10 _BroadcastStreamController.close (dart:async/broadcast_stream_controller.dart:276:5)
#11 _AsBroadcastStreamController.close (dart:async/broadcast_stream_controller.dart:504:27)
#12 _RootZone.runGuarded (dart:async/zone.dart:1302:10)
#13 _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:389:13)
#14 _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:399:15)
#15 _BufferingStreamSubscription._close (dart:async/stream_impl.dart:283:7)
#16 _SyncStreamController._sendDone (dart:async/stream_controller.dart:771:19)
#17 _StreamController._closeUnchecked (dart:async/stream_controller.dart:628:7)
#18 _StreamController.close (dart:async/stream_controller.dart:621:5)
#19 new _RawDatagramSocket.<anonymous closure> (dart:io/runtime/binsocket_patch.dart:1816:23)
#20 _NativeSocket.multiplex (dart:io/runtime/binsocket_patch.dart:899:39)
#21 _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:171:12)
--- Re-run this test:
python tools/test.py -m product -n dartk-linux-product-x64 co19_2/LibTest/io/RawDatagramSocket/lastWhere_A01_t02 |
…flaky Issue dart-lang/co19#170 TBR=kustermann@google.com Change-Id: I7f4dbf8127a044e27773cf331c099839638f98ac Reviewed-on: https://dart-review.googlesource.com/c/81276 Reviewed-by: Vyacheslav Egorov <vegorov@google.com> Commit-Queue: Vyacheslav Egorov <vegorov@google.com> Auto-Submit: Vyacheslav Egorov <vegorov@google.com>
Similarly |
FAILED: dartk-vm product_x64 co19_2/LibTest/io/RawDatagramSocket/listen_A02_t02
Expected: Pass
Actual: RuntimeError
--- Command "vm" (took 818ms):
DART_CONFIGURATION=ProductX64 xcodebuild/ProductX64/dart --sync-async --ignore-unrecognized-flags --packages=/b/s/w/ir/.packages /b/s/w/ir/tests/co19_2/src/LibTest/io/RawDatagramSocket/listen_A02_t02.dart
exit code:
255
stdout:
unittest-suite-wait-for-done
stderr:
Unhandled exception:
deepEquals([0, 1, 2], [0, null, null], ) fails
[cause: Expect.equals(expected: <1>, actual: <null>) fails.]
#0 _fail (file:///b/s/w/ir/tests/co19_2/src/Utils/expect.dart:21:5)
#1 Expect.deepEquals (file:///b/s/w/ir/tests/co19_2/src/Utils/expect_common.dart:375:7)
#2 Expect.listEquals (file:///b/s/w/ir/tests/co19_2/src/Utils/expect_common.dart:303:5)
#3 check.<anonymous closure>.<anonymous closure>.<anonymous closure> (file:///b/s/w/ir/tests/co19_2/src/LibTest/io/RawDatagramSocket/listen_A02_t02.dart:60:16)
#4 _RootZone.runGuarded (dart:async/zone.dart:1302:10)
#5 _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:389:13)
#6 _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:399:15)
#7 _BufferingStreamSubscription._close (dart:async/stream_impl.dart:283:7)
#8 _SyncStreamController._sendDone (dart:async/stream_controller.dart:771:19)
#9 _StreamController._closeUnchecked (dart:async/stream_controller.dart:628:7)
#10 _StreamController.close (dart:async/stream_controller.dart:621:5)
#11 new _RawDatagramSocket.<anonymous closure> (dart:io/runtime/binsocket_patch.dart:1816:23)
#12 _NativeSocket.multiplex (dart:io/runtime/binsocket_patch.dart:899:39)
#13 _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:171:12)
--- Re-run this test:
python tools/test.py -m product -n dartk-mac-product-x64 co19_2/LibTest/io/RawDatagramSocket/listen_A02_t02 This test also does not check the return value of |
Issue: dart-lang/co19#170 Change-Id: I4224d9d9796b94f9ee8485171fd0be4791d6d80a Reviewed-on: https://dart-review.googlesource.com/c/82206 Auto-Submit: Daco Harkes <dacoharkes@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
Ditto for
|
The test sometimes fails with:
The test should only increase the sent counter via
sent++
if the producer actually has sent something, which requires checking the return value ofproducer.send()
.Ideally the test would listen to the socket events on
producer
and only send data when getting awrite
event.The text was updated successfully, but these errors were encountered: