co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t05

[scheglov]

Looks like Expect is not imported.
And topLevelVariable is not declared.

FAILED: dart2analyzer-none release_arm64 co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t05
Expected: Pass
Actual: CompileTimeError

--- Command "dart2analyzer" (took 08.000250s):
DART_CONFIGURATION=ReleaseARM64 sdk/bin/dart --packages=.dart_tool/package_config.json pkg/analyzer_cli/bin/analyzer.dart --use-analysis-driver-memory-byte-store --dart-sdk=/Users/scheglov/Source/Dart/sdk.git/sdk/sdk -Dtest_runner.configuration=custom-configuration-1 --enable-experiment=macros --ignore-unrecognized-flags --packages=/Users/scheglov/Source/Dart/sdk.git/sdk/.dart_tool/package_config.json --format=json /Users/scheglov/Source/Dart/sdk.git/sdk/tests/co19/src/LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t05.dart

unexpected analysis errors in augmented_expression_A01_t05.dart:
- Line 55, column 3: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 56, column 3: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 57, column 3: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 58, column 3: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 59, column 3: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 60, column 3: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 61, column 3: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 62, column 3: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 63, column 3: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

unexpected analysis errors in augmented_expression_A01_t05_lib.dart:
- Line 20, column 1: COMPILE_TIME_ERROR.AUGMENTATION_WITHOUT_DECLARATION
  The declaration being augmented doesn't exist.

- Line 21, column 3: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 25, column 3: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 31, column 5: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 35, column 5: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 39, column 5: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 43, column 5: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 50, column 5: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 54, column 5: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 58, column 5: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 62, column 5: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 71, column 5: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 75, column 5: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 79, column 5: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 83, column 5: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 90, column 5: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 94, column 5: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 98, column 5: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

- Line 102, column 5: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'Expect'.

--- Re-run this test:
python3 tools/test.py -m release -c dart2analyzer -a arm64 co19/LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t05

[scheglov]

I still see errors because Expect is not imported into augmented_expression_A01_t05_lib.dart

[sgrekhov]

After rereading of the spec

Likewise, libraries imported by the augmented library are not implicitly imported by the library augmentation.

The test must be really fixed, missed this, sorry!