Make record positional field getters start at $1.
#1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Jan 16, 2023
eernstg
reviewed
Jan 16, 2023
athomas
approved these changes
Jan 24, 2023
|
PTAL |
|
And I should reload before adding more comments. Ignore me :) |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jan 30, 2023
An update for co19 is available at dart-lang/co19#1759 TEST=Existing tests run after change, two new tests for edge cases. Change-Id: I408e398d532ba2c2e8e60777bb4f7bd0057e27fe Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278912 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com> Reviewed-by: Nicholas Shahan <nshahan@google.com> Reviewed-by: Stephen Adams <sra@google.com> Reviewed-by: Aske Simon Christensen <askesc@google.com>
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jan 30, 2023
2023-01-24 lrn@google.com Make record positional field getters start at `$1`. (dart-lang/co19#1759) 2023-01-23 asashour@yahoo.com Remove superfluous words. (dart-lang/co19#1790) 2023-01-23 asashour@yahoo.com Remove redundant words. (dart-lang/co19#1788) Change-Id: I2ec57a2ecfd922aa5d044dbb710727f40867557a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279516 Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Alexander Thomas <athom@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready in case we change the record positional getter names to starting at
$1.If we do so, this should be landed and then rolled into the CL that changes the SDK: https://dart-review.googlesource.com/c/sdk/+/278912