New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2138. Fix assertions in some functions tests #2140

Merged

eernstg merged 1 commit into dart-lang:master from sgrekhov:co19-2138

Jul 18, 2023

Contributor

sgrekhov commented Jul 18, 2023

No description provided.


          dart-lang#2138. Fix assertions in some functions tests

253ec96

eernstg approved these changes

View reviewed changes

Member

eernstg left a comment

LGTM

eernstg merged commit ed5f316 into dart-lang:master

2 checks passed

sgrekhov requested review from chloestefantsova and eernstg

July 18, 2023 11:25

sgrekhov deleted the co19-2138 branch

July 18, 2023 11:27

copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request


          [co19] Roll co19 to 1530f9b2408f5754c1c114f4d6475d883301f0ca

cc257d8

2023-07-21 sgrekhov22@gmail.com Fixes dart-lang/co19#2141. Add covariant instance variable tests (dart-lang/co19#2144)
2023-07-18 sgrekhov22@gmail.com dart-lang/co19#2138. Fix assertions in some functions tests (dart-lang/co19#2140)
2023-07-17 sgrekhov22@gmail.com Fixes dart-lang/co19#2136. Add type variable conflict test (dart-lang/co19#2137)
2023-07-14 sgrekhov22@gmail.com Fixes dart-lang/co19#2127. Add tests for covariant-by-class parameters (dart-lang/co19#2133)

Change-Id: I0eb608e6bebaf9bcf1acced5e6db98e5ce622979
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/315400
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment