-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2428. Add call
member tests for extension types
#2438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think the @assertion
needs to be revised in some of these tests. It describes invocations, not tear-offs. Another thing is that some tests are about a declaration that 'redeclares' call
: They might benefit from including one more case.
LanguageFeatures/Extension-types/dynamic_semantics_member_invocation_A03_t07.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Extension-types/dynamic_semantics_member_invocation_A03_t07.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Extension-types/dynamic_semantics_member_invocation_A03_t08.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A05_t09.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A05_t09.dart
Show resolved
Hide resolved
LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A05_t09.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A05_t10.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A05_t10.dart
Show resolved
Hide resolved
LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A05_t11.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Please take another look
LanguageFeatures/Extension-types/dynamic_semantics_member_invocation_A03_t07.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A05_t09.dart
Show resolved
Hide resolved
LanguageFeatures/Extension-types/dynamic_semantics_member_invocation_A03_t07.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2024-01-12 sgrekhov22@gmail.com Fixes dart-lang/co19#2480. Fix typos, add issue numbers (dart-lang/co19#2481) 2024-01-10 sgrekhov22@gmail.com dart-lang/co19#2477. Rename and reorder existing constants tests for match operators before adding new ones (dart-lang/co19#2478) 2024-01-10 sgrekhov22@gmail.com dart-lang/co19#2420. Add null-check-pattern tests for extension types (dart-lang/co19#2475) 2024-01-10 sgrekhov22@gmail.com dart-lang/co19#2119. Add missing experimental flags (dart-lang/co19#2474) 2024-01-10 sgrekhov22@gmail.com dart-lang/co19#2119. Fix typo and improve error messages in Timer tests (dart-lang/co19#2473) 2024-01-09 sgrekhov22@gmail.com Fixes dart-lang/co19#2471. Fix timer constructor tests. Add check for microtasks (dart-lang/co19#2472) 2024-01-09 sgrekhov22@gmail.com Fixes dart-lang/co19#2428. Add `call` member tests for extension types (dart-lang/co19#2438) 2024-01-09 sgrekhov22@gmail.com Fixes dart-lang/co19#2449. Update positions of analyzer expected errors (dart-lang/co19#2450) 2024-01-09 sgrekhov22@gmail.com Fixes dart-lang/co19#2440. Add asyncStart/End() to Stream interface tests (dart-lang/co19#2457) 2024-01-09 sgrekhov22@gmail.com dart-lang/co19#2420. Add another variable pattern exhaustiveness test (dart-lang/co19#2469) 2024-01-08 sgrekhov22@gmail.com dart-lang/co19#2420. Add constant pattern exhaustiveness tests (dart-lang/co19#2467) 2024-01-08 sgrekhov22@gmail.com dart-lang/co19#2436. Add expected constant evaluation error for CFE (dart-lang/co19#2470) 2024-01-08 sgrekhov22@gmail.com dart-lang/co19#2420. Add null-assert pattern exhaustiveness tests (dart-lang/co19#2468) 2024-01-05 sgrekhov22@gmail.com dart-lang/co19#2420. Add parenthesized pattern exhaustiveness tests (dart-lang/co19#2464) Change-Id: I86862732cca7c042120bf312403279c2cc10c135 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345960 Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Erik Ernst <eernst@google.com> Reviewed-by: Erik Ernst <eernst@google.com>
No description provided.